From 0106325bc4c526030732490d88ad3d1778b20121 Mon Sep 17 00:00:00 2001 From: Philippe Saint-Pierre Date: Mon, 2 Jan 2012 16:52:52 -0500 Subject: [PATCH] Time preference: Fix a memory leak Accidentally introduced with an earlier commit. --- src/preferences/time/NetworkTimeView.cpp | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/preferences/time/NetworkTimeView.cpp b/src/preferences/time/NetworkTimeView.cpp index f5b8297227..8e85b1ca91 100644 --- a/src/preferences/time/NetworkTimeView.cpp +++ b/src/preferences/time/NetworkTimeView.cpp @@ -175,8 +175,10 @@ Settings::SettingsChanged() return true; fOldMessage.Flatten(oldBytes, oldSize); char* newBytes = new (std::nothrow) char[newSize]; - if (newBytes == NULL) + if (newBytes == NULL) { + delete[] oldBytes; return true; + } fMessage.Flatten(newBytes, newSize); int result = memcmp(oldBytes, newBytes, oldSize);