i2p/haiku-beta6
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

ipv4: Fix PVS 2464

Browse Source 
Fix using local variable within a loop with a same name
as a variable controlling this loop.

Change-Id: Ie920807a56e51b32844ac13ff1d8c564466d3a83
Reviewed-on: https://review.haiku-os.org/751
Reviewed-by: Adrien Destugues <[email protected]>
This commit is contained in:
Murai Takashi
2018-12-11 19:51:20 +00:00
committed by waddlesplash
parent f1e8678942
commit 07af264afa
1 changed files with 7 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/add-ons/kernel/network/protocols/ipv4/ipv4.cpp
+7 -6
View File
@@ -497,10 +497,10 @@ dump_ipv4_header(ipv4_header &header)
static int static int
dump_ipv4_multicast(int argc, char** argv) dump_ipv4_multicast(int argc, char** argv)
{ {
MulticastState::Iterator it = sMulticastState->GetIterator(); MulticastState::Iterator groupIterator = sMulticastState->GetIterator();
while (it.HasNext()) { while (groupIterator.HasNext()) {
IPv4GroupInterface* state = it.Next(); IPv4GroupInterface* state = groupIterator.Next();
char addressBuffer[64]; char addressBuffer[64];
@@ -511,10 +511,11 @@ dump_ipv4_multicast(int argc, char** argv)
? "Exclude" : "Include"); ? "Exclude" : "Include");
int count = 0; int count = 0;
IPv4GroupInterface::AddressSet::Iterator it IPv4GroupInterface::AddressSet::Iterator addressIterator
= state->Sources().GetIterator(); = state->Sources().GetIterator();
while (it.HasNext()) { while (addressIterator.HasNext()) {
kprintf("%s%s", count > 0 ? ", " : "", print_address(&it.Next(), kprintf("%s%s", count > 0 ? ", " : "",
print_address(&addressIterator.Next(),
addressBuffer, sizeof(addressBuffer))); addressBuffer, sizeof(addressBuffer)));
count++; count++;
} }