i2p/haiku-beta6
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

FAT: Limit volume names to 11 characters, not 10.

Browse Source 
The rest of the code does a memcpy(..., ..., min(11, strlen(...))
so clearly no NULL terminator is needed and 11 is the real limit.

Should fix #18074.

Change-Id: I6aea166899eab2bab9511ca52981ccc9172b6c17
Reviewed-on: https://review.haiku-os.org/c/haiku/+/5823
Tested-by: Commit checker robot <[email protected]>
Reviewed-by: Jérôme Duval <[email protected]>
This commit is contained in:
Augustin Cavalier
2022-11-19 01:58:42 +00:00
committed by waddlesplash
parent 5728bdf606
commit 0843085384
1 changed files with 5 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/add-ons/kernel/file_systems/fat/mkdos.cpp
+5 -3
View File
@@ -41,10 +41,12 @@ create_volume_label_sector(void *sector, const char *label)
status_t status_t
check_volume_name(const char* name) check_volume_name(const char* name)
{ {
if (name == NULL || strlen(name) >= 11 if (name == NULL)
|| strchr(name, '/') != NULL) { return B_BAD_VALUE;
if (strlen(name) > 11)
return B_NAME_TOO_LONG;
if (strchr(name, '/') != NULL)
return B_BAD_VALUE; return B_BAD_VALUE;
}
return B_OK; return B_OK;
} }