Patch by kaliber (ticket #6333): Removed many instances of

passing an additional -Wall to the compiler, which may actually
have unwanted effects. -Wall is standard by the build system.
Also, -Wno-multichar was passed unnecessarily for Haiku targets.
I didn't remove it for the bfs_shell, hope this is what Ingo meant
in the ticket.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@39314 a95241bf-73f2-0310-859d-f6bbb57e9c96
This commit is contained in:
Stephan Aßmus
2010-11-05 20:31:11 +00:00
parent 1aa32c3dd0
commit 08e6655afe
35 changed files with 41 additions and 84 deletions
@@ -1,7 +1,5 @@
SubDir HAIKU_TOP src add-ons kernel drivers network 3com pci ; SubDir HAIKU_TOP src add-ons kernel drivers network 3com pci ;
SubDirCcFlags -Wall ;
UseHeaders [ FDirName $(SUBDIR) .. ] : true ; UseHeaders [ FDirName $(SUBDIR) .. ] : true ;
UseHeaders [ FDirName $(HAIKU_TOP) src libs compat freebsd_network compat ] : true ; UseHeaders [ FDirName $(HAIKU_TOP) src libs compat freebsd_network compat ] : true ;
@@ -1,7 +1,5 @@
SubDir HAIKU_TOP src add-ons kernel drivers network atheros813x dev alc ; SubDir HAIKU_TOP src add-ons kernel drivers network atheros813x dev alc ;
SubDirCcFlags -Wall ;
UseHeaders [ FDirName $(HAIKU_TOP) src libs compat freebsd_network compat ] UseHeaders [ FDirName $(HAIKU_TOP) src libs compat freebsd_network compat ]
: true ; : true ;
@@ -1,7 +1,5 @@
SubDir HAIKU_TOP src add-ons kernel drivers network broadcom440x dev bfe ; SubDir HAIKU_TOP src add-ons kernel drivers network broadcom440x dev bfe ;
SubDirCcFlags -Wall ;
UseHeaders [ FDirName $(SUBDIR) .. .. ] : true ; UseHeaders [ FDirName $(SUBDIR) .. .. ] : true ;
UseHeaders [ FDirName $(SUBDIR) .. mii ] : true ; UseHeaders [ FDirName $(SUBDIR) .. mii ] : true ;
UseHeaders [ FDirName $(HAIKU_TOP) src libs compat freebsd_network compat ] : true ; UseHeaders [ FDirName $(HAIKU_TOP) src libs compat freebsd_network compat ] : true ;
@@ -1,7 +1,5 @@
SubDir HAIKU_TOP src add-ons kernel drivers network broadcom570x dev bge ; SubDir HAIKU_TOP src add-ons kernel drivers network broadcom570x dev bge ;
SubDirCcFlags -Wall ;
UseHeaders [ FDirName $(SUBDIR) .. .. ] : true ; UseHeaders [ FDirName $(SUBDIR) .. .. ] : true ;
UseHeaders [ FDirName $(SUBDIR) .. mii ] : true ; UseHeaders [ FDirName $(SUBDIR) .. mii ] : true ;
UseHeaders [ FDirName $(HAIKU_TOP) src libs compat freebsd_network compat ] : true ; UseHeaders [ FDirName $(HAIKU_TOP) src libs compat freebsd_network compat ] : true ;
@@ -2,9 +2,6 @@ SubDir HAIKU_TOP src add-ons kernel drivers network dp83815 ;
SetSubDirSupportedPlatformsBeOSCompatible ; SetSubDirSupportedPlatformsBeOSCompatible ;
# set some additional flags
SubDirCcFlags -Wall ;
# For ether_driver.h # For ether_driver.h
UsePrivateHeaders net ; UsePrivateHeaders net ;
@@ -2,9 +2,6 @@ SubDir HAIKU_TOP src add-ons kernel drivers network etherpci ;
SetSubDirSupportedPlatformsBeOSCompatible ; SetSubDirSupportedPlatformsBeOSCompatible ;
# set some additional flags
SubDirCcFlags -Wall ;
# For ether_driver.h # For ether_driver.h
UsePrivateHeaders net ; UsePrivateHeaders net ;
@@ -1,7 +1,5 @@
SubDir HAIKU_TOP src add-ons kernel drivers network ipro100 dev fxp ; SubDir HAIKU_TOP src add-ons kernel drivers network ipro100 dev fxp ;
SubDirCcFlags -Wall ;
UseHeaders [ FDirName $(SUBDIR) .. .. ] : true ; UseHeaders [ FDirName $(SUBDIR) .. .. ] : true ;
UseHeaders [ FDirName $(HAIKU_TOP) src libs compat freebsd_network compat ] : true ; UseHeaders [ FDirName $(HAIKU_TOP) src libs compat freebsd_network compat ] : true ;
@@ -2,9 +2,6 @@ SubDir HAIKU_TOP src add-ons kernel drivers network ipro1000 ;
SetSubDirSupportedPlatformsBeOSCompatible ; SetSubDirSupportedPlatformsBeOSCompatible ;
# set some additional flags
SubDirCcFlags -Wall ;
# For ether_driver.h # For ether_driver.h
UsePrivateHeaders net ; UsePrivateHeaders net ;
@@ -1,7 +1,5 @@
SubDir HAIKU_TOP src add-ons kernel drivers network jmicron2x0 dev jme ; SubDir HAIKU_TOP src add-ons kernel drivers network jmicron2x0 dev jme ;
SubDirCcFlags -Wall ;
UseHeaders [ FDirName $(SUBDIR) .. .. ] : true ; UseHeaders [ FDirName $(SUBDIR) .. .. ] : true ;
UseHeaders [ FDirName $(SUBDIR) .. mii ] : true ; UseHeaders [ FDirName $(SUBDIR) .. mii ] : true ;
UseHeaders [ FDirName $(HAIKU_TOP) src libs compat freebsd_network compat ] : true ; UseHeaders [ FDirName $(HAIKU_TOP) src libs compat freebsd_network compat ] : true ;
@@ -1,7 +1,5 @@
SubDir HAIKU_TOP src add-ons kernel drivers network pcnet dev le ; SubDir HAIKU_TOP src add-ons kernel drivers network pcnet dev le ;
SubDirCcFlags -Wall ;
UsePrivateHeaders kernel net ; UsePrivateHeaders kernel net ;
UseHeaders [ FDirName $(SUBDIR) .. .. ] : true ; UseHeaders [ FDirName $(SUBDIR) .. .. ] : true ;
@@ -2,9 +2,6 @@ SubDir HAIKU_TOP src add-ons kernel drivers network rtl8169 ;
SetSubDirSupportedPlatformsBeOSCompatible ; SetSubDirSupportedPlatformsBeOSCompatible ;
# set some additional flags
SubDirCcFlags -Wall ;
# For ether_driver.h # For ether_driver.h
UsePrivateHeaders net ; UsePrivateHeaders net ;
@@ -2,8 +2,6 @@ SubDir HAIKU_TOP src add-ons kernel drivers network sis900 ;
SetSubDirSupportedPlatformsBeOSCompatible ; SetSubDirSupportedPlatformsBeOSCompatible ;
# set some additional flags
SubDirCcFlags -Wall ;
# For ether_driver.h # For ether_driver.h
UsePrivateHeaders net ; UsePrivateHeaders net ;
@@ -1,7 +1,5 @@
SubDir HAIKU_TOP src add-ons kernel drivers network via_rhine pci ; SubDir HAIKU_TOP src add-ons kernel drivers network via_rhine pci ;
SubDirCcFlags -Wall ;
UseHeaders [ FDirName $(SUBDIR) .. ] : true ; UseHeaders [ FDirName $(SUBDIR) .. ] : true ;
UseHeaders [ FDirName $(HAIKU_TOP) src libs compat freebsd_network compat ] : true ; UseHeaders [ FDirName $(HAIKU_TOP) src libs compat freebsd_network compat ] : true ;
@@ -2,9 +2,6 @@ SubDir HAIKU_TOP src add-ons kernel drivers network vlance ;
SetSubDirSupportedPlatformsBeOSCompatible ; SetSubDirSupportedPlatformsBeOSCompatible ;
# set some additional flags
SubDirCcFlags -Wall ;
# For ether_driver.h # For ether_driver.h
UsePrivateHeaders net ; UsePrivateHeaders net ;
@@ -3,8 +3,6 @@ SubDir HAIKU_TOP src add-ons kernel drivers network wb840 ;
SetSubDirSupportedPlatformsBeOSCompatible ; SetSubDirSupportedPlatformsBeOSCompatible ;
# set some additional flags # set some additional flags
SubDirCcFlags -Wall ;
# For ether_driver.h # For ether_driver.h
UsePrivateHeaders net ; UsePrivateHeaders net ;
@@ -14,7 +14,7 @@ SubDirCcFlags [ FDefines _KERNEL=1 FBSD_DRIVER=1 ]
-Wno-format -Wno-format
-Wno-unused -Wno-unused
-Wno-uninitialized -Wno-uninitialized
-Wall ; ;
UseHeaders [ FDirName $(SUBDIR) ] : true ; UseHeaders [ FDirName $(SUBDIR) ] : true ;
+2 -2
View File
@@ -20,8 +20,8 @@ SubDir HAIKU_TOP src add-ons kernel file_systems bfs ;
} }
defines = [ FDefines $(defines) ] ; defines = [ FDefines $(defines) ] ;
SubDirCcFlags $(defines) -Wall -Wno-multichar ; SubDirCcFlags $(defines) ;
SubDirC++Flags $(defines) -Wall -Wno-multichar ; SubDirC++Flags $(defines) ;
} }
UsePrivateKernelHeaders ; UsePrivateKernelHeaders ;
@@ -1,11 +1,5 @@
SubDir HAIKU_TOP src add-ons kernel file_systems ext2 ; SubDir HAIKU_TOP src add-ons kernel file_systems ext2 ;
# set some additional defines
{
SubDirCcFlags -Wall -Wno-multichar ;
SubDirC++Flags -Wall -Wno-multichar ;
}
#UsePrivateHeaders [ FDirName kernel disk_device_manager ] ; #UsePrivateHeaders [ FDirName kernel disk_device_manager ] ;
UsePrivateHeaders [ FDirName kernel util ] ; UsePrivateHeaders [ FDirName kernel util ] ;
UsePrivateHeaders shared storage ; UsePrivateHeaders shared storage ;
@@ -3,8 +3,7 @@ SubDir HAIKU_TOP src add-ons kernel file_systems iso9660 ;
UsePrivateHeaders kernel ; UsePrivateHeaders kernel ;
# set some additional defines # set some additional defines
SubDirCcFlags -Wall -Wno-multichar ; SubDirC++Flags -fno-rtti ;
SubDirC++Flags -Wall -Wno-multichar -fno-rtti ;
KernelAddon iso9660 : KernelAddon iso9660 :
iso9660.cpp iso9660.cpp
@@ -1,7 +1,5 @@
SubDir HAIKU_TOP src add-ons kernel file_systems ntfs libntfs ; SubDir HAIKU_TOP src add-ons kernel file_systems ntfs libntfs ;
SubDirCcFlags -Wall -Wno-multichar ;
DEFINES += HAVE_CONFIG_H=1 ; DEFINES += HAVE_CONFIG_H=1 ;
KernelStaticLibrary libntfs.a : KernelStaticLibrary libntfs.a :
@@ -21,8 +21,8 @@ oldOPTIM = $(OPTIM) ;
} }
defines = [ FDefines $(defines) ] ; defines = [ FDefines $(defines) ] ;
SubDirCcFlags $(defines) -Wall -Wno-multichar ; SubDirCcFlags $(defines) -Wno-multichar ;
SubDirC++Flags $(defines) -Wall -Wno-multichar ; SubDirC++Flags $(defines) -Wno-multichar ;
} }
UsePrivateHeaders [ FDirName kernel util ] ; UsePrivateHeaders [ FDirName kernel util ] ;
+2 -1
View File
@@ -2,7 +2,8 @@ SubDir HAIKU_TOP src bin bzip2 ;
# set some additional defines # set some additional defines
{ {
SubDirCcFlags -Wall -Winline -O2 -fomit-frame-pointer -fno-strength-reduce -D_FILE_OFFSET_BITS=64 -w ; SubDirCcFlags -Winline -O2 -fomit-frame-pointer -fno-strength-reduce
-D_FILE_OFFSET_BITS=64 -w ;
} }
local bzip2_rsrc = [ FGristFiles bzip2.rsrc ] ; local bzip2_rsrc = [ FGristFiles bzip2.rsrc ] ;
+2 -2
View File
@@ -46,8 +46,8 @@ UsePrivateHeaders shared storage ;
} }
defines = [ FDefines $(defines) ] ; defines = [ FDefines $(defines) ] ;
SubDirCcFlags $(defines) -Wall -Wno-multichar ; SubDirCcFlags $(defines) ;
SubDirC++Flags $(defines) -Wall -Wno-multichar -fno-rtti ; SubDirC++Flags $(defines) -fno-rtti ;
} }
KernelStaticLibrary boot_loader : KernelStaticLibrary boot_loader :
+4 -4
View File
@@ -13,8 +13,8 @@ UsePrivateHeaders [ FDirName storage ] ;
local defines = _BOOT_MODE ; local defines = _BOOT_MODE ;
defines = [ FDefines $(defines) ] ; defines = [ FDefines $(defines) ] ;
SubDirCcFlags $(defines) -Wall -Wno-multichar ; SubDirCcFlags $(defines) ;
SubDirC++Flags $(defines) -Wall -Wno-multichar -fno-rtti ; SubDirC++Flags $(defines) -fno-rtti ;
} }
#SEARCH_SOURCE += [ FDirName $(HAIKU_TOP) src add-ons accelerants common ] ; #SEARCH_SOURCE += [ FDirName $(HAIKU_TOP) src add-ons accelerants common ] ;
@@ -52,9 +52,9 @@ KernelMergeObject boot_platform_amiga_m68k_other.o :
# support.S # support.S
video.cpp video.cpp
#apm.cpp #apm.cpp
$(genericPlatformSources) $(genericPlatformSources)
# VESA/DDC EDID # VESA/DDC EDID
#decode_edid.c #decode_edid.c
#dump_edid.c #dump_edid.c
+4 -4
View File
@@ -13,8 +13,8 @@ UsePrivateHeaders [ FDirName storage ] ;
local defines = _BOOT_MODE ; local defines = _BOOT_MODE ;
defines = [ FDefines $(defines) ] ; defines = [ FDefines $(defines) ] ;
SubDirCcFlags $(defines) -Wall -Wno-multichar ; SubDirCcFlags $(defines) ;
SubDirC++Flags $(defines) -Wall -Wno-multichar -fno-rtti ; SubDirC++Flags $(defines) -fno-rtti ;
} }
#SEARCH_SOURCE += [ FDirName $(HAIKU_TOP) src add-ons accelerants common ] ; #SEARCH_SOURCE += [ FDirName $(HAIKU_TOP) src add-ons accelerants common ] ;
@@ -50,7 +50,7 @@ KernelMergeObject boot_platform_atari_m68k_other.o :
# support.S # support.S
video.cpp video.cpp
#apm.cpp #apm.cpp
# generic # generic
text_menu.cpp text_menu.cpp
@@ -119,7 +119,7 @@ rule AtariBootPrgLd
LocalDepends all : $(1) ; LocalDepends all : $(1) ;
Depends $(1) : $(2) ; Depends $(1) : $(2) ;
MakeLocateDebug $(1) ; MakeLocateDebug $(1) ;
} }
+2 -2
View File
@@ -11,8 +11,8 @@ UsePrivateHeaders [ FDirName storage ] ;
local defines = _BOOT_MODE ; local defines = _BOOT_MODE ;
defines = [ FDefines $(defines) ] ; defines = [ FDefines $(defines) ] ;
SubDirCcFlags $(defines) -Wall -Wno-multichar ; SubDirCcFlags $(defines) ;
SubDirC++Flags $(defines) -Wall -Wno-multichar -fno-rtti ; SubDirC++Flags $(defines) -fno-rtti ;
} }
SEARCH_SOURCE += [ FDirName $(HAIKU_TOP) src add-ons accelerants common ] ; SEARCH_SOURCE += [ FDirName $(HAIKU_TOP) src add-ons accelerants common ] ;
+2 -2
View File
@@ -13,8 +13,8 @@ UsePrivateHeaders [ FDirName storage ] ;
local defines = _BOOT_MODE _PXE_ENV ; local defines = _BOOT_MODE _PXE_ENV ;
defines = [ FDefines $(defines) ] ; defines = [ FDefines $(defines) ] ;
SubDirCcFlags $(defines) -Wall -Wno-multichar ; SubDirCcFlags $(defines) ;
SubDirC++Flags $(defines) -Wall -Wno-multichar -fno-rtti ; SubDirC++Flags $(defines) -fno-rtti ;
} }
local genericPlatformSources = local genericPlatformSources =
@@ -11,13 +11,13 @@ UsePrivateHeaders [ FDirName storage ] ;
local defines = _BOOT_MODE ; local defines = _BOOT_MODE ;
defines = [ FDefines $(defines) ] ; defines = [ FDefines $(defines) ] ;
SubDirCcFlags $(defines) -Wall -Wno-multichar ; SubDirCcFlags $(defines) ;
SubDirC++Flags $(defines) -Wall -Wno-multichar -fno-rtti ; SubDirC++Flags $(defines) -fno-rtti ;
} }
SEARCH_SOURCE += [ FDirName $(HAIKU_TOP) src add-ons accelerants common ] ; SEARCH_SOURCE += [ FDirName $(HAIKU_TOP) src add-ons accelerants common ] ;
local genericPlatformSources = local genericPlatformSources =
text_menu.cpp text_menu.cpp
# video_blit.cpp # video_blit.cpp
# video_splash.cpp # video_splash.cpp
+2 -2
View File
@@ -17,8 +17,8 @@ UsePrivateHeaders [ FDirName kernel arch arm board $(TARGET_BOOT_BOARD) ] ;
local defines = _BOOT_MODE ; local defines = _BOOT_MODE ;
defines = [ FDefines $(defines) ] ; defines = [ FDefines $(defines) ] ;
SubDirCcFlags $(defines) -Wall -Wno-multichar -g3 ; SubDirCcFlags $(defines) -g3 ;
SubDirC++Flags $(defines) -Wall -Wno-multichar -fno-rtti -g3 ; SubDirC++Flags $(defines) -fno-rtti -g3 ;
} }
# we fake NetBSD since we don't have an OS ID yet for uimage, # we fake NetBSD since we don't have an OS ID yet for uimage,
@@ -33,8 +33,8 @@ oldOPTIM = $(OPTIM) ;
} }
defines = [ FDefines $(defines) ] ; defines = [ FDefines $(defines) ] ;
SubDirCcFlags $(defines) -Wall -Wno-multichar ; SubDirCcFlags $(defines) ;
SubDirC++Flags $(defines) -Wall -Wno-multichar -fno-rtti ; SubDirC++Flags $(defines) -fno-rtti ;
} }
UsePrivateHeaders [ FDirName kernel ] ; # For kernel_cpp.cpp UsePrivateHeaders [ FDirName kernel ] ; # For kernel_cpp.cpp
@@ -59,7 +59,7 @@ KernelAddon $(bfsAddOnName)_r5 :
; ;
SEARCH on [ FGristFiles SEARCH on [ FGristFiles
kernel_cpp.cpp kernel_cpp.cpp
] = [ FDirName $(HAIKU_TOP) src system kernel util ] ; ] = [ FDirName $(HAIKU_TOP) src system kernel util ] ;
#----------------------------------------------------- #-----------------------------------------------------
@@ -8,8 +8,8 @@ SEARCH_SOURCE
# set some additional defines # set some additional defines
{ {
local defines = [ FDefines FS_SHELL USER DEBUG ] ; local defines = [ FDefines FS_SHELL USER DEBUG ] ;
SubDirCcFlags $(defines) -Wall -Wno-multichar ; SubDirCcFlags $(defines) ;
SubDirC++Flags $(defines) -Wall -Wno-multichar -fno-exceptions ; SubDirC++Flags $(defines) -fno-exceptions ;
} }
local libHaikuCompat ; local libHaikuCompat ;
@@ -20,8 +20,8 @@ oldOPTIM = $(OPTIM) ;
} }
defines = [ FDefines $(defines) ] ; defines = [ FDefines $(defines) ] ;
SubDirCcFlags $(defines) -Wall -Wno-multichar ; SubDirCcFlags $(defines) ;
SubDirC++Flags $(defines) -Wall -Wno-multichar ; SubDirC++Flags $(defines) ;
} }
UsePrivateHeaders kernel ; # For kernel_cpp.cpp UsePrivateHeaders kernel ; # For kernel_cpp.cpp
@@ -47,7 +47,7 @@ KernelAddon <r5>udf :
; ;
SEARCH on [ FGristFiles SEARCH on [ FGristFiles
kernel_cpp.cpp kernel_cpp.cpp
] = [ FDirName $(HAIKU_TOP) src system kernel util ] ; ] = [ FDirName $(HAIKU_TOP) src system kernel util ] ;
@@ -23,8 +23,8 @@ oldOPTIM = $(OPTIM) ;
} }
defines = [ FDefines $(defines) ] ; defines = [ FDefines $(defines) ] ;
SubDirCcFlags $(defines) -Wall -Wno-multichar ; SubDirCcFlags $(defines) ;
SubDirC++Flags $(defines) -Wall -Wno-multichar ; SubDirC++Flags $(defines) ;
} }
UsePrivateHeaders [ FDirName kernel util ] ; UsePrivateHeaders [ FDirName kernel util ] ;
@@ -17,8 +17,8 @@ SEARCH_SOURCE += $(bfsTop) ;
} }
defines = [ FDefines $(defines) ] ; defines = [ FDefines $(defines) ] ;
SubDirCcFlags $(defines) -Wall -Wno-multichar ; SubDirCcFlags $(defines) ;
SubDirC++Flags $(defines) -Wall -Wno-multichar -fno-rtti ; SubDirC++Flags $(defines) -fno-rtti ;
} }
UsePrivateKernelHeaders ; UsePrivateKernelHeaders ;
+2 -2
View File
@@ -18,8 +18,8 @@ DEFINES += HAIKU_BUILD_COMPATIBILITY_H ;
} }
defines = [ FDefines $(defines) ] ; defines = [ FDefines $(defines) ] ;
SubDirCcFlags $(defines) -Wall -Wno-multichar ; SubDirCcFlags $(defines) -Wno-multichar ;
SubDirC++Flags $(defines) -Wall -Wno-multichar -fno-rtti ; SubDirC++Flags $(defines) -Wno-multichar -fno-rtti ;
} }
local libHaikuCompat ; local libHaikuCompat ;