From 09a5380d0c49121a56de52a1ec8d452030a5fca5 Mon Sep 17 00:00:00 2001 From: Murai Takashi Date: Tue, 25 Dec 2018 06:54:03 +0900 Subject: [PATCH] CharacterSetRoster: Fix PVS 528-530 Remove unneed if conditions, since unsigned type value is never < 0. Change-Id: I76621f79883752cd3560c6e02f18384b1ddd9cf3 Reviewed-on: https://review.haiku-os.org/797 Reviewed-by: Barrett17 --- src/kits/textencoding/CharacterSetRoster.cpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/kits/textencoding/CharacterSetRoster.cpp b/src/kits/textencoding/CharacterSetRoster.cpp index 7c5f044477..3546038463 100644 --- a/src/kits/textencoding/CharacterSetRoster.cpp +++ b/src/kits/textencoding/CharacterSetRoster.cpp @@ -56,7 +56,7 @@ BCharacterSetRoster::StopWatching(BMessenger target) const BCharacterSet * BCharacterSetRoster::GetCharacterSetByFontID(uint32 id) { - if ((id < 0) || (id >= character_sets_by_id_count)) { + if (id >= character_sets_by_id_count) { return NULL; } return character_sets_by_id[id]; @@ -65,7 +65,7 @@ BCharacterSetRoster::GetCharacterSetByFontID(uint32 id) const BCharacterSet * BCharacterSetRoster::GetCharacterSetByConversionID(uint32 id) { - if ((id+1 < 0) || (id+1 >= character_sets_by_id_count)) { + if (id + 1 >= character_sets_by_id_count) { return NULL; } return character_sets_by_id[id+1]; @@ -74,7 +74,7 @@ BCharacterSetRoster::GetCharacterSetByConversionID(uint32 id) const BCharacterSet * BCharacterSetRoster::GetCharacterSetByMIBenum(uint32 MIBenum) { - if ((MIBenum < 0) || (MIBenum > maximum_valid_MIBenum)) { + if (MIBenum > maximum_valid_MIBenum) { return NULL; } return character_sets_by_MIBenum[MIBenum];