fs_shell: Prevent inclusion of BSD headers; fix DeviceOpener.

headers/private/file_systems/DeviceOpener.h

@@ -6,7 +6,14 @@
 #ifndef DEVICEOPENER_H
 #define DEVICEOPENER_H
 
-#include "system_dependencies.h"
+#ifdef FS_SHELL
+#	include "fssh_api_wrapper.h"
+#else
+#	include <fcntl.h>
+#	include <sys/types.h>
+#	include <SupportDefs.h>
+#endif
+
 
 class DeviceOpener {
 	public:

src/add-ons/kernel/file_systems/bfs/system_dependencies.h

@@ -8,8 +8,6 @@
 
 #ifdef FS_SHELL
 
-#include <new>
-
 #include "fssh_api_wrapper.h"
 #include "fssh_auto_deleter.h"
 

src/add-ons/kernel/file_systems/shared/DeviceOpener.cpp

@@ -4,9 +4,14 @@
  */
 
 
-#include "system_dependencies.h"
 #include "file_systems/DeviceOpener.h"
 
+#ifndef FS_SHELL
+#	include <errno.h>
+#	include <Drivers.h>
+#	include <fs_cache.h>
+#endif
+
 
 DeviceOpener::DeviceOpener(const char* device, int mode)
 	:

src/add-ons/kernel/file_systems/shared/system_dependencies.h

@@ -1,38 +0,0 @@
-#ifndef _SYSTEM_DEPENDENCIES_H
-#define _SYSTEM_DEPENDENCIES_H
-
-#ifdef FS_SHELL
-// This needs to be included before the fs_shell wrapper
-
-#include "fssh_api_wrapper.h"
-#include "fssh_auto_deleter.h"
-//#include <new>
-
-#else // !FS_SHELL
-
-#include <AutoDeleter.h>
-#include <util/AutoLock.h>
-#include <util/DoublyLinkedList.h>
-#include <util/SinglyLinkedList.h>
-#include <util/Stack.h>
-
-#include <ByteOrder.h>
-
-#include <tracing.h>
-#include <driver_settings.h>
-#include <fs_attr.h>
-#include <fs_cache.h>
-#include <fs_index.h>
-#include <fs_info.h>
-#include <fs_interface.h>
-#include <fs_query.h>
-#include <fs_volume.h>
-#include <Drivers.h>
-#include <errno.h>
-#include <KernelExport.h>
-#include <NodeMonitor.h>
-#include <SupportDefs.h>
-#include <TypeConstants.h>
-#endif // !FS_SHELL
-
-#endif // _SYSTEM_DEPENDENCIES

src/tests/add-ons/kernel/file_systems/btrfs/btrfs_shell/Jamfile

@@ -2,8 +2,8 @@ SubDir HAIKU_TOP src tests add-ons kernel file_systems btrfs btrfs_shell ;
 
 SEARCH_SOURCE += [ FDirName $(HAIKU_TOP) src add-ons kernel file_systems btrfs ] ;
 
-# prevent inclusion of HaikuBuildCompatibility.h
+# prevent inclusion of HaikuBuildCompatibility.h and _BSD_SOURCE headers
-DEFINES += HAIKU_BUILD_COMPATIBILITY_H ;
+DEFINES += HAIKU_BUILD_COMPATIBILITY_H __STRICT_ANSI__ ;
 
 # set some additional defines
 {

src/tests/add-ons/kernel/file_systems/iso9660/iso9660_shell/Jamfile

@@ -3,8 +3,8 @@ SubDir HAIKU_TOP src tests add-ons kernel file_systems iso9660 iso9660_shell ;
 SEARCH_SOURCE
 	+= [ FDirName $(HAIKU_TOP) src add-ons kernel file_systems iso9660 ] ;
 
-# prevent inclusion of HaikuBuildCompatibility.h
+# prevent inclusion of HaikuBuildCompatibility.h and _BSD_SOURCE headers
-DEFINES += HAIKU_BUILD_COMPATIBILITY_H ;
+DEFINES += HAIKU_BUILD_COMPATIBILITY_H __STRICT_ANSI__ ;
 
 # set some additional defines
 {

src/tests/add-ons/kernel/file_systems/udf/udf_shell/Jamfile

@@ -2,8 +2,8 @@ SubDir HAIKU_TOP src tests add-ons kernel file_systems udf udf_shell ;
 
 SEARCH_SOURCE += [ FDirName $(HAIKU_TOP) src add-ons kernel file_systems udf ] ;
 
-# prevent inclusion of HaikuBuildCompatibility.h
+# prevent inclusion of HaikuBuildCompatibility.h and _BSD_SOURCE headers
-DEFINES += HAIKU_BUILD_COMPATIBILITY_H ;
+DEFINES += HAIKU_BUILD_COMPATIBILITY_H __STRICT_ANSI__ ;
 
 # set some additional defines
 {

src/tests/add-ons/kernel/file_systems/ufs2/ufs2_shell/Jamfile

@@ -2,8 +2,8 @@ SubDir HAIKU_TOP src tests add-ons kernel file_systems ufs2 ufs2_shell ;
 
 SEARCH_SOURCE += [ FDirName $(HAIKU_TOP) src add-ons kernel file_systems ufs2 ] ;
 
-# prevent inclusion of HaikuBuildCompatibility.h
+# prevent inclusion of HaikuBuildCompatibility.h and _BSD_SOURCE headers
-DEFINES += HAIKU_BUILD_COMPATIBILITY_H ;
+DEFINES += HAIKU_BUILD_COMPATIBILITY_H __STRICT_ANSI__ ;
 
 # set some additional defines
 {

src/tests/add-ons/kernel/file_systems/xfs/xfs_shell/Jamfile

@@ -2,8 +2,8 @@ SubDir HAIKU_TOP src tests add-ons kernel file_systems xfs xfs_shell ;
 
 SEARCH_SOURCE += [ FDirName $(HAIKU_TOP) src add-ons kernel file_systems xfs ] ;
 
-# prevent inclusion of HaikuBuildCompatibility.h
+# prevent inclusion of HaikuBuildCompatibility.h and _BSD_SOURCE headers
-DEFINES += HAIKU_BUILD_COMPATIBILITY_H ;
+DEFINES += HAIKU_BUILD_COMPATIBILITY_H __STRICT_ANSI__ ;
 
 # set some additional defines
 {
@@ -68,4 +68,4 @@ SEARCH on [ FGristFiles QueryParserUtils.cpp ]
 	+= [ FDirName $(HAIKU_TOP) src add-ons kernel file_systems shared ] ;
 
 SEARCH on [ FGristFiles DeviceOpener.cpp ]
-	+= [ FDirName $(HAIKU_TOP) src add-ons kernel file_systems shared ] ;
+	+= [ FDirName $(HAIKU_TOP) src add-ons kernel file_systems shared ] ;

src/tools/bfs_shell/Jamfile

@@ -2,8 +2,8 @@ SubDir HAIKU_TOP src tools bfs_shell ;
 
 SEARCH_SOURCE += [ FDirName $(HAIKU_TOP) src add-ons kernel file_systems bfs ] ;
 
-# prevent inclusion of HaikuBuildCompatibility.h
+# prevent inclusion of HaikuBuildCompatibility.h and BSD headers
-DEFINES += HAIKU_BUILD_COMPATIBILITY_H ;
+DEFINES += HAIKU_BUILD_COMPATIBILITY_H __STRICT_ANSI__ ;
 
 # set some additional defines
 {

src/tools/fs_shell/Jamfile

@@ -14,8 +14,8 @@ UsePrivateHeaders shared ;
 
 DEFINES += FS_SHELL=1 ;
 
-# prevent inclusion of HaikuBuildCompatibility.h
+# prevent inclusion of HaikuBuildCompatibility.h and _BSD_SOURCE headers
-DEFINES += HAIKU_BUILD_COMPATIBILITY_H ;
+DEFINES += HAIKU_BUILD_COMPATIBILITY_H __STRICT_ANSI__ ;
 
 # platform specific sources/libraries
 local fsShellCommandSources ;