no Invalidate in BControl::SetValue, I figure more controls need to be updated for this change

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@12947 a95241bf-73f2-0310-859d-f6bbb57e9c96
2005-06-03 19:55:49 +00:00
parent 743a147353
commit 0c3344f4a1
6 changed files with 205 additions and 175 deletions
@@ -101,8 +101,7 @@ BCheckBox::Draw(BRect updateRect)
 	darken4 = tint_color(no_tint, B_DARKEN_4_TINT),
 	darkenmax = tint_color(no_tint, B_DARKEN_MAX_TINT);

-	BRect rect(1.0f, 3.0f, (float)ceil(3.0f + fontHeight.ascent),
-		(float)ceil(5.0f + fontHeight.ascent));
+	BRect rect = _CheckBoxFrame();

 	if (IsEnabled()) {
 		// Filling
@@ -350,7 +349,10 @@ BCheckBox::DetachedFromWindow()
 void
 BCheckBox::SetValue(int32 value)
 {
-	BControl::SetValue(value);
+	if (value != Value()) {
+		BControl::SetValue(value);
+		Invalidate(_CheckBoxFrame());
+	}
 }


@@ -452,3 +454,13 @@ BCheckBox::operator=(const BCheckBox &)
 {
 	return *this;
 }
+
+// _CheckBoxFrame
+BRect
+BCheckBox::_CheckBoxFrame() const
+{
+	font_height fh;
+	GetFontHeight(&fh);
+
+	return BRect(1.0f, 3.0f, ceilf(3.0f + fh.ascent), ceilf(5.0f + fh.ascent));
+}