From 0c4d8bc572a5014c659af92fc49a05bf7646bbaa Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Stephan=20A=C3=9Fmus?= Date: Fri, 21 Apr 2006 10:09:53 +0000 Subject: [PATCH] * added TODO in DragMessage about using an area for the message * removed TODO in DragMessage about reference counting, since it already happens * use _FlushIfNotInTransaction when moving/resizing a view programmatically, so that it usually happens instantly. git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@17186 a95241bf-73f2-0310-859d-f6bbb57e9c96 --- src/kits/interface/View.cpp | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/src/kits/interface/View.cpp b/src/kits/interface/View.cpp index 621514611c..149a6d1853 100644 --- a/src/kits/interface/View.cpp +++ b/src/kits/interface/View.cpp @@ -1314,6 +1314,8 @@ BView::DragMessage(BMessage *message, BBitmap *image, BMessage::Private privateMessage(message); privateMessage.SetReply(BMessenger(replyTo, replyTo->Looper())); + // TODO: create area and flatten message into that area! + // send area info over port, not the actual message! int32 bufferSize = privateMessage.NativeFlattenedSize(); char* buffer = new (nothrow) char[bufferSize]; if (buffer) { @@ -1337,9 +1339,6 @@ BView::DragMessage(BMessage *message, BBitmap *image, fprintf(stderr, "BView::DragMessage() - no memory to flatten drag message\n"); } - // TODO: in app_server the bitmap refCount must be incremented - // WRITE this into specs!!!! - delete image; } @@ -3443,6 +3442,8 @@ BView::MoveTo(float x, float y) fOwner->fLink->Attach(y); fState->valid_flags |= B_VIEW_FRAME_BIT; + + _FlushIfNotInTransaction(); } _MoveTo(x, y); @@ -3476,6 +3477,8 @@ BView::ResizeBy(float deltaWidth, float deltaHeight) fOwner->fLink->Attach(fBounds.bottom + deltaHeight); fState->valid_flags |= B_VIEW_FRAME_BIT; + + _FlushIfNotInTransaction(); } _ResizeBy(deltaWidth, deltaHeight);