i2p/haiku-beta6
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Unit tests to ensure robust handling of bogus params to convenience funcs

Browse Source 
plus fixes for the bugs they exposes.


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@3416 a95241bf-73f2-0310-859d-f6bbb57e9c96
This commit is contained in:
ejakowatz
2003-06-03 23:22:08 +00:00
parent 575526ff34
commit 0cc48ce6f9
5 changed files with 141 additions and 80 deletions
Download Patch File Download Diff File Expand all files Collapse all files
headers/private/app/MessageBody.h
+44 -40
View File
@@ -119,7 +119,7 @@ status_t BMessageBody::AddData(const char *name, const T1 &data, type_code type)
{
// The flattened message format in R5 only allows 1 byte
// for the length of field names
if (strlen(name) > 255) return B_BAD_VALUE;
if (!name || (strlen(name) > 255)) return B_BAD_VALUE;
status_t err = B_OK;
BMessageField* BMF = FindData(name, type, err);
@@ -158,31 +158,33 @@ template<class T1>
status_t BMessageBody::FindData(const char *name, int32 index, T1 *data,
type_code type)
{
status_t err = B_OK;
if (!name)
{
return B_BAD_VALUE;
}
if (index < 0)
{
err = B_BAD_INDEX;
return B_BAD_INDEX;
}
else
status_t err = B_OK;
BMessageField* Item = FindData(name, type, err);
if (Item)
{
BMessageField* Item = FindData(name, type, err);
if (Item)
BMessageFieldImpl<T1>* RItem =
dynamic_cast<BMessageFieldImpl<T1>*>(Item);
if (!RItem)
{
BMessageFieldImpl<T1>* RItem =
dynamic_cast<BMessageFieldImpl<T1>*>(Item);
if (!RItem)
{
debugger("\n\n\tyou \033[44;1;37mB\033[41;1;37me"
"\033[m screwed\n\n");
}
if (index < RItem->CountItems())
{
*data = RItem->Data()[index];
}
else
{
err = B_BAD_INDEX;
}
debugger("\n\n\tyou \033[44;1;37mB\033[41;1;37me"
"\033[m screwed\n\n");
}
if (index < RItem->CountItems())
{
*data = RItem->Data()[index];
}
else
{
err = B_BAD_INDEX;
}
}
@@ -193,30 +195,32 @@ template<class T1>
status_t BMessageBody::ReplaceData(const char *name, int32 index,
const T1 &data, type_code type)
{
status_t err = B_OK;
if (!name)
{
return B_BAD_VALUE;
}
if (index < 0)
{
err = B_BAD_INDEX;
return B_BAD_INDEX;
}
else
status_t err = B_OK;
BMessageField* Item = FindData(name, type, err);
if (Item)
{
BMessageField* Item = FindData(name, type, err);
if (Item)
BMessageFieldImpl<T1>* RItem =
dynamic_cast<BMessageFieldImpl<T1>*>(Item);
if (!RItem)
{
BMessageFieldImpl<T1>* RItem =
dynamic_cast<BMessageFieldImpl<T1>*>(Item);
if (!RItem)
{
debugger("\n\n\tyou \033[44;1;37mB\033[41;1;37me\033[m screwed\n\n");
}
if (index < RItem->Data().Size())
{
RItem->Data()[index] = data;
}
else
{
err = B_BAD_INDEX;
}
debugger("\n\n\tyou \033[44;1;37mB\033[41;1;37me\033[m screwed\n\n");
}
if (index < RItem->Data().Size())
{
RItem->Data()[index] = data;
}
else
{
err = B_BAD_INDEX;
}
}