From 0ee4261ea88fd968eb3977cce85a771bf8591cb9 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Stephan=20A=C3=9Fmus?= <superstippi@gmx.de>
Date: Thu, 21 Jan 2010 14:39:08 +0000
Subject: [PATCH]  * Don't return positive status_t in Load() instead of B_OK. 
 * Small coding style corrections.

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@35219 a95241bf-73f2-0310-859d-f6bbb57e9c96
---
 src/preferences/keymap/Keymap.cpp | 14 ++++++++------
 1 file changed, 8 insertions(+), 6 deletions(-)

diff --git a/src/preferences/keymap/Keymap.cpp b/src/preferences/keymap/Keymap.cpp
index cba8c84a6c..19cf7362b5 100644
--- a/src/preferences/keymap/Keymap.cpp
+++ b/src/preferences/keymap/Keymap.cpp
@@ -141,7 +141,7 @@ Keymap::Load(entry_ref &ref)
 		return B_BAD_VALUE;
 	}
 
-	for (uint32 i=0; i<sizeof(fKeys)/4; i++)
+	for (uint32 i = 0; i < sizeof(fKeys) / 4; i++)
 		((uint32*)&fKeys)[i] = B_BENDIAN_TO_HOST_INT32(((uint32*)&fKeys)[i]);
 
 	if ((err = file.Read(&fCharsSize, sizeof(uint32))) < (ssize_t)sizeof(uint32)) {
@@ -154,19 +154,21 @@ Keymap::Load(entry_ref &ref)
 
 	fChars = new char[fCharsSize];
 
-	err = file.Read(fChars, fCharsSize);
-	if (err < B_OK) {
+	ssize_t bytesRead = file.Read(fChars, fCharsSize);
+	if (bytesRead < 0) {
 		fprintf(stderr, "error reading keymap chars: %s\n", strerror(err));
+		return (status_t)bytesRead;
 	}
 
 	// fetch name from attribute and fall back to filename
-	ssize_t bytesRead
-		= file.ReadAttr("keymap:name", B_STRING_TYPE, 0, fName, sizeof(fName));
+	
+	bytesRead = file.ReadAttr("keymap:name", B_STRING_TYPE, 0, fName,
+		sizeof(fName));
 	if (bytesRead > 0)
 		fName[bytesRead] = '\0';
 	else
 		strlcpy(fName, ref.name, sizeof(fName));
-	return err;
+	return B_OK;
 }