From 0f098ae692176f48b6b7cc177c1b391145e2936d Mon Sep 17 00:00:00 2001 From: John Scipione Date: Tue, 17 Mar 2026 20:04:45 -0400 Subject: [PATCH] Tracker: Check FSGetTrashDir() status, GetNextRef() is faster Change-Id: I4f700a9170bc86aea73e4f9959ef05d1a4ddd6da Reviewed-on: https://review.haiku-os.org/c/haiku/+/10635 Tested-by: Commit checker robot Reviewed-by: waddlesplash --- src/kits/tracker/TrashWatcher.cpp | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/src/kits/tracker/TrashWatcher.cpp b/src/kits/tracker/TrashWatcher.cpp index 2df752ee46..164fa4bc9e 100644 --- a/src/kits/tracker/TrashWatcher.cpp +++ b/src/kits/tracker/TrashWatcher.cpp @@ -213,11 +213,13 @@ BTrashWatcher::CheckTrashDirs() continue; BDirectory trashDir; - FSGetTrashDir(&trashDir, volume.Device()); - trashDir.Rewind(); - BEntry entry; - if (trashDir.GetNextEntry(&entry) == B_OK) - return true; + if (FSGetTrashDir(&trashDir, volume.Device()) == B_OK) { + trashDir.Rewind(); + // GetNextRef() is a bit faster than GetNextEntry() + entry_ref ref; + if (trashDir.GetNextRef(&ref) == B_OK) + return true; + } } return false;