i2p/haiku-beta6
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

build: Add stub _get_thread_info() needed by support/Referenceable.cpp

Browse Source 
This is a step towards fixing #10042.

When DEBUG is set BReferenceable::~BReferenceable() performs some checks
ensuring that the object is destroyed correctly. These checks require
information on thread stack, which is obtained by get_thread_info().

_get_thread_info() stub is added (actually, readded) which always returns
B_ERROR. Moreover, the check in BReferenceable destructor is modified
so that it does not fail when get_thread_info() fails.
This commit is contained in:
Pawel Dziepak
2013-10-01 15:06:17 +02:00
parent d46d383800
commit 1238bebddc
2 changed files with 7 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/build/libroot/thread.cpp
+5 -5
View File
@@ -38,11 +38,11 @@ find_thread(const char *name)
} }
// _get_thread_info // _get_thread_info
// status_t status_t
// _get_thread_info(thread_id id, thread_info *info, size_t size) _get_thread_info(thread_id id, thread_info* info, size_t size)
// { {
// return B_ERROR; return B_ERROR;
// } }
// _get_next_thread_info // _get_next_thread_info
// status_t // status_t
src/kits/support/Referenceable.cpp
+2 -2
View File
@@ -47,8 +47,8 @@ BReferenceable::~BReferenceable()
// stack range to be sure. // stack range to be sure.
thread_info info; thread_info info;
status_t result = get_thread_info(find_thread(NULL), &info); status_t result = get_thread_info(find_thread(NULL), &info);
if (result != B_OK || this < info.stack_base if (result == B_OK && (this < info.stack_base
|| this > info.stack_end) { || this > info.stack_end)) {
snprintf(message, sizeof(message), "Deleted referenceable " snprintf(message, sizeof(message), "Deleted referenceable "
"object that's not on the stack (this: %p, stack_base: %p," "object that's not on the stack (this: %p, stack_base: %p,"
" stack_end: %p)\n", this, info.stack_base, " stack_end: %p)\n", this, info.stack_base,