From 14652ec4bbec3795d791bb50ba1a47f802f7aee8 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Stephan=20A=C3=9Fmus?= Date: Wed, 22 Jan 2014 18:00:31 +0100 Subject: [PATCH] trim support code: The passed in MemoryDeleter was never used. When a buffer has to be allocated, I guess the intention was to assign the MemoryDeleter to it, so that it would later be freed. CID 1130505 --- headers/private/kernel/util/fs_trim_support.h | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/headers/private/kernel/util/fs_trim_support.h b/headers/private/kernel/util/fs_trim_support.h index e36ca5335e..22e6f9ac41 100644 --- a/headers/private/kernel/util/fs_trim_support.h +++ b/headers/private/kernel/util/fs_trim_support.h @@ -43,6 +43,10 @@ get_trim_data_from_user(void* buffer, size_t size, MemoryDeleter& deleter, return B_BAD_ADDRESS; } + // The passed in MemoryDeleter needs to take care of freeing the buffer + // later, since we had to allocate it. + deleter.SetTo(trimBuffer); + _trimData = (fs_trim_data*)trimBuffer; return B_OK; }