From 15cc2a1fad4c67ece238f5f20c9bae4607cf7c05 Mon Sep 17 00:00:00 2001 From: John Scipione Date: Mon, 31 Mar 2014 20:08:44 -0400 Subject: [PATCH] Time prefs: Set pointer NULL, delete in destructor ... avoiding potential memory leak. --- src/preferences/time/NetworkTimeView.cpp | 21 +++++++++++++++++++++ src/preferences/time/NetworkTimeView.h | 1 + 2 files changed, 22 insertions(+) diff --git a/src/preferences/time/NetworkTimeView.cpp b/src/preferences/time/NetworkTimeView.cpp index 4c4c5adb0d..82ce72050b 100644 --- a/src/preferences/time/NetworkTimeView.cpp +++ b/src/preferences/time/NetworkTimeView.cpp @@ -269,6 +269,14 @@ NetworkTimeView::NetworkTimeView(const char* name) : BGroupView(name, B_VERTICAL, B_USE_DEFAULT_SPACING), fSettings(), + fServerTextControl(NULL), + fAddButton(NULL), + fRemoveButton(NULL), + fResetButton(NULL), + fServerListView(NULL), + fTryAllServersCheckBox(NULL), + fSynchronizeAtBootCheckBox(NULL), + fSynchronizeButton(NULL), fUpdateThread(-1) { fSettings.Load(); @@ -276,6 +284,19 @@ NetworkTimeView::NetworkTimeView(const char* name) } +NetworkTimeView::~NetworkTimeView() +{ + delete fServerTextControl; + delete fAddButton; + delete fRemoveButton; + delete fResetButton; + delete fServerListView; + delete fTryAllServersCheckBox; + delete fSynchronizeAtBootCheckBox; + delete fSynchronizeButton; +} + + void NetworkTimeView::MessageReceived(BMessage* message) { diff --git a/src/preferences/time/NetworkTimeView.h b/src/preferences/time/NetworkTimeView.h index 3a56826c96..3a494555c8 100644 --- a/src/preferences/time/NetworkTimeView.h +++ b/src/preferences/time/NetworkTimeView.h @@ -84,6 +84,7 @@ private: class NetworkTimeView : public BGroupView { public: NetworkTimeView(const char* name); + virtual ~NetworkTimeView(); virtual void MessageReceived(BMessage* message); virtual void AttachedToWindow();