From 16081dd2fa89fbc51c11ad907bed751a8a2b36ab Mon Sep 17 00:00:00 2001 From: Augustin Cavalier Date: Thu, 3 Nov 2022 20:24:24 -0400 Subject: [PATCH] libshared: Enable hidden visibility. This breaks ABI as we forgot to do this originally and a lot of apps implicitly use symbols from libbe or elsewhere that are imported from libshared, but we are about to branch beta4, so now is the time to change this. Fixes #17256. --- src/kits/shared/Jamfile | 4 ---- 1 file changed, 4 deletions(-) diff --git a/src/kits/shared/Jamfile b/src/kits/shared/Jamfile index e757519260..ebf144fa13 100644 --- a/src/kits/shared/Jamfile +++ b/src/kits/shared/Jamfile @@ -24,10 +24,6 @@ for architectureObject in [ MultiArchSubDirSetup ] { # for BKeymap UsePrivateHeaders interface ; - # FIXME: These symbols should be hidden, but too many applications depend - # on them at present for that. - NO_HIDDEN_VISIBILITY on <$(architecture)>libshared.a = 1 ; - StaticLibrary <$(architecture)>libshared.a : AboutMenuItem.cpp ArgumentVector.cpp