i2p/haiku-beta6
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

bootloader: Avoid allocating the logo image in kernel_args space.

Browse Source 
We never send it to the kernel but always free it. The kernel_args
allocator is very simple and can't handle frees besides the most recent
data, so this avoids "leaking" some kernel_args memory (it should all
be freed by the kernel later, though, so that only matters for
the bootloader itself.)
This commit is contained in:
Augustin Cavalier
2026-04-24 12:48:48 -04:00
parent 46c9f1a94a
commit 1c2f998214
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/system/boot/platform/generic/video_splash.cpp
+3 -3
View File
@@ -138,7 +138,7 @@ video_display_splash(addr_t frameBuffer)
switch (gKernelArgs.frame_buffer.depth) { switch (gKernelArgs.frame_buffer.depth) {
case 8: case 8:
platform_set_palette(k8BitPalette); platform_set_palette(k8BitPalette);
uncompressedLogo = (uint8*)kernel_args_malloc(uncompressedSize); uncompressedLogo = (uint8*)malloc(uncompressedSize);
if (uncompressedLogo == NULL) if (uncompressedLogo == NULL)
return B_NO_MEMORY; return B_NO_MEMORY;
@@ -148,7 +148,7 @@ video_display_splash(addr_t frameBuffer)
break; break;
default: // 24 bits is assumed here default: // 24 bits is assumed here
uncompressedSize *= 3; uncompressedSize *= 3;
uncompressedLogo = (uint8*)kernel_args_malloc(uncompressedSize); uncompressedLogo = (uint8*)malloc(uncompressedSize);
if (uncompressedLogo == NULL) if (uncompressedLogo == NULL)
return B_NO_MEMORY; return B_NO_MEMORY;
@@ -167,7 +167,7 @@ video_display_splash(addr_t frameBuffer)
video_blit_image(frameBuffer, uncompressedLogo, width, height, video_blit_image(frameBuffer, uncompressedLogo, width, height,
kSplashLogoWidth, x, y); kSplashLogoWidth, x, y);
kernel_args_free(uncompressedLogo); free(uncompressedLogo);
const uint8* lowerHalfIconImage; const uint8* lowerHalfIconImage;
uncompressedSize = kSplashIconsWidth * kSplashIconsHeight; uncompressedSize = kSplashIconsWidth * kSplashIconsHeight;