From 1c3b53c4461f9d05504d7cf5977c927d68d8054a Mon Sep 17 00:00:00 2001 From: Murai Takashi Date: Tue, 27 Aug 2024 19:52:39 +0900 Subject: [PATCH] FindPanel: fix branch condition evaluates to a garbage value Fixed dynamicDate used without initialization at line 730, since GetPredicateString() might not set value to dynamicDate. Pointed out by Clang Static Analyzer. Change-Id: I4698fdada4b91183c7bdba5aa980ddc6b55e6312 Reviewed-on: https://review.haiku-os.org/c/haiku/+/7946 Reviewed-by: waddlesplash Haiku-Format: Haiku-format Bot Tested-by: Commit checker robot --- src/kits/tracker/FindPanel.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/kits/tracker/FindPanel.cpp b/src/kits/tracker/FindPanel.cpp index 4d9a8c4f61..67d3e2e3b3 100644 --- a/src/kits/tracker/FindPanel.cpp +++ b/src/kits/tracker/FindPanel.cpp @@ -723,7 +723,7 @@ FindWindow::SaveQueryAsAttributes(BNode* file, BEntry* entry, bool queryTemplate ? B_QUERY_TEMPLATE_MIMETYPE : B_QUERY_MIMETYPE); BString predicate; - bool dynamicDate; + bool dynamicDate = false; GetPredicateString(predicate, dynamicDate); file->WriteAttrString(kAttrQueryString, &predicate);