From 1d0064be8b306320008ee7d953460b604ba98c8c Mon Sep 17 00:00:00 2001 From: Murai Takashi Date: Wed, 6 Feb 2019 06:15:49 +0900 Subject: [PATCH] file_systems/netfs/server: Fix attempting to delete released memory Remove 'delete securityContext;' at line 967, since 'securityContext' will be deleted by ObjectDeleter. Pointed by clang static analyzer. Change-Id: Iffcd6e2b293d5614fa15ee108562ff1f5f23ddc9 Reviewed-on: https://review.haiku-os.org/c/1011 Reviewed-by: waddlesplash --- src/add-ons/kernel/file_systems/netfs/server/NetFSServer.cpp | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/add-ons/kernel/file_systems/netfs/server/NetFSServer.cpp b/src/add-ons/kernel/file_systems/netfs/server/NetFSServer.cpp index 324b271243..bb8b9e2f3a 100644 --- a/src/add-ons/kernel/file_systems/netfs/server/NetFSServer.cpp +++ b/src/add-ons/kernel/file_systems/netfs/server/NetFSServer.cpp @@ -963,10 +963,8 @@ NetFSServer::_LoadSettings() RETURN_ERROR(B_NO_MEMORY); ObjectDeleter securityContextDeleter(securityContext); error = securityContext->InitCheck(); - if (error != B_OK) { - delete securityContext; + if (error != B_OK) RETURN_ERROR(error); - } // set it delete fSecurityContext;