From 1e9cdb0bd8b5c58627915caf0f518ab5c43b4da4 Mon Sep 17 00:00:00 2001 From: Murai Takashi Date: Thu, 25 Jun 2020 06:25:13 +0900 Subject: [PATCH] bin/setversion: Fix if condition Fix str = "gm" could not be checked. Pointed out by cppcheck. Change-Id: I433a98cef851e07be0905eee2f5100a02fa6a32b Reviewed-on: https://review.haiku-os.org/c/haiku/+/2949 Reviewed-by: waddlesplash --- src/bin/setversion.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/bin/setversion.cpp b/src/bin/setversion.cpp index b27ba12762..e99d673f8e 100644 --- a/src/bin/setversion.cpp +++ b/src/bin/setversion.cpp @@ -62,7 +62,7 @@ convertVariety(const char *str) return 2; if (!strcmp(str, "g") || !strcmp(str, "gamma")) return 3; - if (strcmp(str, "gm") || !strcmp(str, "goldenmaster")) + if (!strcmp(str, "gm") || !strcmp(str, "goldenmaster")) return 4; if (!strcmp(str, "f") || !strcmp(str, "final")) return 5;