From 211cb77acf9db0db465b353292b21707179ca975 Mon Sep 17 00:00:00 2001
From: Rene Gollent <rene@gollent.com>
Date: Thu, 14 Jun 2018 16:38:49 -0400
Subject: [PATCH] Debugger: don't auto-download packages non-interactively.

- When in non-interactive mode, i.e. saving a crash report, don't
  allow the image debug info loader to automatically grab missing but
  available info packages. Otherwise we potentially download very large
  packages with the user being entirely unaware, i.e. the 200MB debug
  information package now present by default for gcc7's libgcc. This
  should eventually be made a configurable preference though.
---
 .../loading_state_handlers/DwarfLoadingStateHandler.cpp     | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/src/kits/debugger/debug_info/loading_state_handlers/DwarfLoadingStateHandler.cpp b/src/kits/debugger/debug_info/loading_state_handlers/DwarfLoadingStateHandler.cpp
index 9cc89e0cc6..fc313a7a78 100644
--- a/src/kits/debugger/debug_info/loading_state_handlers/DwarfLoadingStateHandler.cpp
+++ b/src/kits/debugger/debug_info/loading_state_handlers/DwarfLoadingStateHandler.cpp
@@ -99,10 +99,8 @@ DwarfLoadingStateHandler::HandleState(
 				choice = interface->SynchronouslyAskUser("Debug info missing",
 					message.String(), "Install", "Locate", "Skip");
 			}
-		} else {
-			choice = requiredPackage.IsEmpty()
-				? USER_CHOICE_SKIP : USER_CHOICE_INSTALL_PACKAGE;
-		}
+		} else
+			choice = USER_CHOICE_SKIP;
 
 		if (choice == USER_CHOICE_INSTALL_PACKAGE) {
 			// TODO: integrate the package installation functionality directly.