From 21e5fc49a70cccc13e033a1e62b281dab27b1ea2 Mon Sep 17 00:00:00 2001 From: Adrien Destugues Date: Fri, 21 Nov 2014 11:18:43 +0100 Subject: [PATCH] Update the hardware view on Pulse() This lets the network stats update in realtime. Fixes #11395. --- .../network/InterfacesAddOn/InterfaceHardwareView.cpp | 10 ++++++++++ .../network/InterfacesAddOn/InterfaceHardwareView.h | 1 + .../network/InterfacesAddOn/InterfacesAddOn.cpp | 1 - .../network/InterfacesAddOn/InterfacesListView.cpp | 2 -- 4 files changed, 11 insertions(+), 3 deletions(-) diff --git a/src/preferences/network/InterfacesAddOn/InterfaceHardwareView.cpp b/src/preferences/network/InterfacesAddOn/InterfaceHardwareView.cpp index 4485d69012..9c1f8e8589 100644 --- a/src/preferences/network/InterfacesAddOn/InterfaceHardwareView.cpp +++ b/src/preferences/network/InterfacesAddOn/InterfaceHardwareView.cpp @@ -44,6 +44,8 @@ InterfaceHardwareView::InterfaceHardwareView(NetworkSettings* settings) { SetLayout(new BGroupLayout(B_VERTICAL)); + SetFlags(Flags() | B_PULSE_NEEDED); + // TODO : Small graph of throughput? float minimumWidth = be_control_look->DefaultItemSpacing() * 16; @@ -163,6 +165,14 @@ InterfaceHardwareView::MessageReceived(BMessage* message) } +void +InterfaceHardwareView::Pulse() +{ + // TODO maybe not everything needs to be updated here. + Update(); +} + + // #pragma mark - InterfaceHardwareView public methods diff --git a/src/preferences/network/InterfacesAddOn/InterfaceHardwareView.h b/src/preferences/network/InterfacesAddOn/InterfaceHardwareView.h index abb4cbb1bf..36f8a5477f 100644 --- a/src/preferences/network/InterfacesAddOn/InterfaceHardwareView.h +++ b/src/preferences/network/InterfacesAddOn/InterfaceHardwareView.h @@ -33,6 +33,7 @@ public: virtual void MessageReceived(BMessage* message); virtual void AttachedToWindow(); + void Pulse(); status_t Revert(); status_t Save(); diff --git a/src/preferences/network/InterfacesAddOn/InterfacesAddOn.cpp b/src/preferences/network/InterfacesAddOn/InterfacesAddOn.cpp index 25c9ab5d18..d8a3ad09b6 100644 --- a/src/preferences/network/InterfacesAddOn/InterfacesAddOn.cpp +++ b/src/preferences/network/InterfacesAddOn/InterfacesAddOn.cpp @@ -126,7 +126,6 @@ InterfacesAddOn::MessageReceived(BMessage* msg) break; default: - msg->PrintToStream(); BBox::MessageReceived(msg); } } diff --git a/src/preferences/network/InterfacesAddOn/InterfacesListView.cpp b/src/preferences/network/InterfacesAddOn/InterfacesListView.cpp index 23a577dad8..be31545d2c 100644 --- a/src/preferences/network/InterfacesAddOn/InterfacesListView.cpp +++ b/src/preferences/network/InterfacesAddOn/InterfacesListView.cpp @@ -549,8 +549,6 @@ InterfacesListView::_HandleNetworkMessage(BMessage* message) const char* name; int32 opcode; - message->PrintToStream(); - if (message->FindInt32("opcode", &opcode) != B_OK) return;