From 2247591422f72cc31235399a61d9ca40652d209a Mon Sep 17 00:00:00 2001 From: Ingo Weinhold Date: Tue, 26 Nov 2013 01:55:58 +0100 Subject: [PATCH] bindfs: Add some TODOs --- .../kernel/file_systems/bindfs/kernel_interface.cpp | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/src/add-ons/kernel/file_systems/bindfs/kernel_interface.cpp b/src/add-ons/kernel/file_systems/bindfs/kernel_interface.cpp index f078961c9f..86080c4e5f 100644 --- a/src/add-ons/kernel/file_systems/bindfs/kernel_interface.cpp +++ b/src/add-ons/kernel/file_systems/bindfs/kernel_interface.cpp @@ -29,6 +29,12 @@ TODO: path filter, such that /dev can be bind-mounted with only a subset of entries + + TODO: Since the source node IDs are used for our nodes, this doesn't work + for source trees with submounts. + + TODO: There's no file cache support (required for mmap()). We implement the + hooks, but they aren't used. */ @@ -228,6 +234,10 @@ bindfs_remove_vnode(fs_volume* fsVolume, fs_vnode* fsNode, bool reenter) // #pragma mark - VM access +// TODO: These hooks are obsolete. Since we don't create a file cache, they +// aren't needed anyway. + + static bool bindfs_can_page(fs_volume* fsVolume, fs_vnode* fsNode, void* cookie) { @@ -282,6 +292,9 @@ bindfs_write_pages(fs_volume* fsVolume, fs_vnode* fsNode, void* cookie, // #pragma mark - Request I/O +// TODO: Since we don't create a file cache, these hooks aren't needed. + + static status_t bindfs_io(fs_volume* fsVolume, fs_vnode* fsNode, void* cookie, io_request* request)