From 24ffd29c7dcd23552ad6d482fb3b9b16c776bd29 Mon Sep 17 00:00:00 2001 From: Murai Takashi Date: Tue, 28 Jan 2020 20:21:09 +0900 Subject: [PATCH] runtime_loader: Fix PVS V595 Add NULL check for fValuesResolved, since malloc() might return NULL. Change-Id: I3849ddfcffd7712fec3d90546244c6b17e4d0f77 Reviewed-on: https://review.haiku-os.org/c/haiku/+/2202 Reviewed-by: waddlesplash --- src/system/runtime_loader/elf_symbol_lookup.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/system/runtime_loader/elf_symbol_lookup.h b/src/system/runtime_loader/elf_symbol_lookup.h index f3f031b40f..dbe5251c72 100644 --- a/src/system/runtime_loader/elf_symbol_lookup.h +++ b/src/system/runtime_loader/elf_symbol_lookup.h @@ -69,7 +69,8 @@ struct SymbolLookupCache { size_t elementCount = (fTableSize + 31) / 32; fValuesResolved = (uint32*)malloc(4 * elementCount); - memset(fValuesResolved, 0, 4 * elementCount); + if (fValuesResolved != NULL) + memset(fValuesResolved, 0, 4 * elementCount); if (fValues == NULL || fDSOs == NULL || fValuesResolved == NULL) { free(fValuesResolved);