From 267d1d780c710d431aee4fb22b9c05820187c48d Mon Sep 17 00:00:00 2001 From: Adrien Destugues Date: Thu, 7 Aug 2014 13:50:25 +0200 Subject: [PATCH] More efficient clearing of the entryList. As pointed out by Ingo, using RemoveAt(0) here is needlessly inneficient. --- src/kits/tracker/PoseViewScripting.cpp | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/kits/tracker/PoseViewScripting.cpp b/src/kits/tracker/PoseViewScripting.cpp index 5966096cd1..41781bb630 100644 --- a/src/kits/tracker/PoseViewScripting.cpp +++ b/src/kits/tracker/PoseViewScripting.cpp @@ -466,9 +466,8 @@ BPoseView::DeleteProperty(BMessage* specifier, int32 form, } else Delete(entryList, false, settings.AskBeforeDeleteFile()); } else { - entry_ref* ref; - while ((ref = entryList->RemoveItemAt(0)) != NULL) - delete ref; + for (int i = 0; i < entryList->CountItems(); i++) + delete entryList->ItemAt(i); delete entryList; }