From 26da5fe367890a9a7329ffc678149d075979b40c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Stephan=20A=C3=9Fmus?= Date: Thu, 16 Oct 2008 09:19:43 +0000 Subject: [PATCH] * Do not delete the private data of the BMessage! This fixes a crash when dragging and dropping icons from one FileTypes window to another (in case the dragged icon was a vector icon). * Checked the other similar places, but all seems fine. Added a comment in one place why no data is leaked, although it may seem to at first sight. git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@28159 a95241bf-73f2-0310-859d-f6bbb57e9c96 --- src/preferences/filetypes/IconView.cpp | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/preferences/filetypes/IconView.cpp b/src/preferences/filetypes/IconView.cpp index 774e7b2a1f..5ec0f3e5ee 100644 --- a/src/preferences/filetypes/IconView.cpp +++ b/src/preferences/filetypes/IconView.cpp @@ -80,7 +80,7 @@ icon_for_type(const BMimeType& type, uint8** _data, size_t* _size, if (source != kNoIcon) { *_data = data; *_size = size; - } + } // NOTE: else there is no data, so nothing is leaked. if (_source) *_source = source; @@ -599,7 +599,6 @@ IconView::MessageReceived(BMessage* message) delete large; delete mini; - delete data; return; }