Fix coding style pointed out by Axel. Thanks for the array trick haven't known this one :-)

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@42539 a95241bf-73f2-0310-859d-f6bbb57e9c96

src/servers/app/Jamfile

@@ -5,7 +5,7 @@ UsePrivateHeaders app graphics input interface kernel shared storage support ;
 
 UseHeaders [ FDirName $(HAIKU_TOP) src servers app drawing ] ;
 UseHeaders [ FDirName $(HAIKU_TOP) src servers app drawing Painter ] ;
-UseHeaders [ FDirName $(HAIKU_TOP) src servers app StackAndTile ] ;
+UseHeaders [ FDirName $(HAIKU_TOP) src servers app stackandtile ] ;
 UseFreeTypeHeaders ;
 
 
@@ -81,7 +81,7 @@ Server app_server :
 	:
 	libtranslation.so libbe.so libbnetapi.so
 	libasdrawing.a libasremote.a libpainter.a libagg.a libfreetype.so
-	StackAndTile.a liblinprog.a libtextencoding.so libshared.a
+	libstackandtile.a liblinprog.a libtextencoding.so libshared.a
 	$(TARGET_LIBSTDC++)
 
 	: app_server.rdef
@@ -92,4 +92,4 @@ SEARCH on [ FGristFiles $(font_src) ] = [ FDirName $(HAIKU_TOP) src servers app
 
 
 SubInclude HAIKU_TOP src servers app drawing ;
-SubInclude HAIKU_TOP src servers app StackAndTile ;
+SubInclude HAIKU_TOP src servers app stackandtile ;

src/servers/app/stackandtile/Jamfile

@@ -1,4 +1,4 @@
-SubDir HAIKU_TOP src servers app StackAndTile ;
+SubDir HAIKU_TOP src servers app stackandtile ;
 
 UseLibraryHeaders agg lp_solve linprog ;
 UsePrivateHeaders app graphics interface shared kernel ;
@@ -10,7 +10,7 @@ UseHeaders [ FDirName $(HAIKU_TOP) src servers app drawing ] ;
 UseHeaders [ FDirName $(HAIKU_TOP) src servers app drawing Painter ] ;
 UseFreeTypeHeaders ;
 
-StaticLibrary StackAndTile.a :
+StaticLibrary libstackandtile.a :
 	SATDecorator.cpp
 	SATGroup.cpp
 	SATWindow.cpp

src/servers/app/stackandtile/SATGroup.cpp

@@ -66,17 +66,8 @@ bool
 WindowArea::MoveWindowToPosition(SATWindow* window, int32 index)
 {
 	int32 oldIndex = fWindowList.IndexOf(window);
-	if (oldIndex < 0)
-		return false;
 	ASSERT(oldIndex != index);
-	if (oldIndex < index)
+	return fWindowList.MoveItem(oldIndex, index);
-		index++;
-	else
-		oldIndex++;
-	if (!fWindowList.AddItem(window, index))
-		return false;
-	fWindowList.RemoveItemAt(oldIndex);
-	return true;
 }
 
 
@@ -94,8 +85,7 @@ WindowArea::_AddWindow(SATWindow* window, SATWindow* after)
 		int32 indexAfter = fWindowList.IndexOf(after);
 		if (!fWindowList.AddItem(window, indexAfter + 1))
 			return false;
-	}
+	} else if (fWindowList.AddItem(window) == false)
-	else if (!fWindowList.AddItem(window))
 		return false;
 
 	AcquireReference();
@@ -361,7 +351,14 @@ Crossing::~Crossing()
 Corner*
 Crossing::GetCorner(Corner::position_t corner) const
 {
-	return _GetCorner(corner);
+	return &const_cast<Corner*>(fCorners)[corner];
+}
+
+
+Corner*
+Crossing::GetOppositeCorner(Corner::position_t corner) const
+{
+	return &const_cast<Corner*>(fCorners)[3 - corner];
 }
 
 
@@ -383,47 +380,13 @@ void
 Crossing::Trace() const
 {
 	STRACE_SAT("left-top corner: ");
-	fLeftTop.Trace();
+	fCorners[Corner::kLeftTop].Trace();
 	STRACE_SAT("right-top corner: ");
-	fRightTop.Trace();
+	fCorners[Corner::kRightTop].Trace();
 	STRACE_SAT("left-bottom corner: ");
-	fLeftBottom.Trace();
+	fCorners[Corner::kLeftBottom].Trace();
 	STRACE_SAT("right-bottom corner: ");
-	fRightBottom.Trace();
+	fCorners[Corner::kRightBottom].Trace();
-}
-
-
-Corner*
-Crossing::_GetCorner(Corner::position_t corner) const
-{
-	switch (corner) {
-		case Corner::kLeftTop:
-			return const_cast<Corner*>(&fLeftTop);
-		case Corner::kRightTop:
-			return const_cast<Corner*>(&fRightTop);
-		case Corner::kLeftBottom:
-			return const_cast<Corner*>(&fLeftBottom);
-		case Corner::kRightBottom:
-			return const_cast<Corner*>(&fRightBottom);
-	};
-	return NULL;
-}
-
-
-Corner*
-Crossing::GetOppositeCorner(Corner::position_t corner) const
-{
-	switch (corner) {
-		case Corner::kLeftTop:
-			return const_cast<Corner*>(&fRightBottom);
-		case Corner::kRightTop:
-			return const_cast<Corner*>(&fLeftBottom);
-		case Corner::kLeftBottom:
-			return const_cast<Corner*>(&fRightTop);
-		case Corner::kRightBottom:
-			return const_cast<Corner*>(&fLeftTop);
-	};
-	return NULL;
 }
 
 
@@ -520,14 +483,16 @@ int32
 Tab::FindCrossingIndex(Tab* tab)
 {
 	if (fOrientation == kVertical) {
-		for (int32 i = 0; i < fCrossingList.CountItems(); i++)
+		for (int32 i = 0; i < fCrossingList.CountItems(); i++) {
 			if (fCrossingList.ItemAt(i)->HorizontalTab() == tab)
 				return i;
+		}
 	} else {
-		for (int32 i = 0; i < fCrossingList.CountItems(); i++)
+		for (int32 i = 0; i < fCrossingList.CountItems(); i++) {
 			if (fCrossingList.ItemAt(i)->VerticalTab() == tab)
 				return i;
 		}
+	}
 	return -1;
 }
 
@@ -536,14 +501,16 @@ int32
 Tab::FindCrossingIndex(float pos)
 {
 	if (fOrientation == kVertical) {
-		for (int32 i = 0; i < fCrossingList.CountItems(); i++)
+		for (int32 i = 0; i < fCrossingList.CountItems(); i++) {
 			if (fCrossingList.ItemAt(i)->HorizontalTab()->Position() == pos)
 				return i;
+		}
 	} else {
-		for (int32 i = 0; i < fCrossingList.CountItems(); i++)
+		for (int32 i = 0; i < fCrossingList.CountItems(); i++) {
 			if (fCrossingList.ItemAt(i)->VerticalTab()->Position() == pos)
 				return i;
 		}
+	}
 	return -1;
 }
 

src/servers/app/stackandtile/SATGroup.h

@@ -35,10 +35,10 @@ public:
 
 		enum position_t
 		{
-			kLeftTop,
+			kLeftTop = 0,
-			kRightTop,
+			kRightTop = 1,
-			kLeftBottom,
+			kLeftBottom = 2,
-			kRightBottom
+			kRightBottom = 3
 		};
 
 						Corner();
@@ -58,22 +58,21 @@ public:
 			Corner*				GetOppositeCorner(
 									Corner::position_t corner) const;
 
-			Corner*				LeftTopCorner() { return &fLeftTop; }
+			Corner*				LeftTopCorner()
-			Corner*				RightTopCorner() { return &fRightTop; }
+									{ return &fCorners[Corner::kLeftTop]; }
-			Corner*				LeftBottomCorner() { return &fLeftBottom; }
+			Corner*				RightTopCorner()
-			Corner*				RightBottomCorner() { return &fRightBottom; }
+									{ return &fCorners[Corner::kRightTop]; }
+			Corner*				LeftBottomCorner()
+									{ return &fCorners[Corner::kLeftBottom]; }
+			Corner*				RightBottomCorner()
+									{ return &fCorners[Corner::kRightBottom]; }
 
 			Tab*				VerticalTab() const;
 			Tab*				HorizontalTab() const;
 
 			void				Trace() const;
 private:
-		Corner*		_GetCorner(Corner::position_t corner) const;
+		Corner		fCorners[4];
-
-		Corner		fLeftTop;
-		Corner		fRightTop;
-		Corner		fLeftBottom;
-		Corner		fRightBottom;
 
 		Tab*		fVerticalTab;
 		Tab*		fHorizontalTab;