* Moved Referenceable.cpp to src/kits/support (private libbe API), and its header to

private/shared.
* Made AddReference() and CountReferences() inlines.
* The registrar is now using the private Referenceable version in libbe.so.
* Minor cleanup.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@21767 a95241bf-73f2-0310-859d-f6bbb57e9c96

headers/private/shared/AutoDeleter.h

@@ -1,35 +1,16 @@
-//------------------------------------------------------------------------------
+/*
-//	Copyright (c) 2001-2002, OpenBeOS
+ * Copyright 2001-2007, Ingo Weinhold, [email protected]. All rights reserved.
-//
+ * Distributed under the terms of the MIT License.
-//	Permission is hereby granted, free of charge, to any person obtaining a
+ */
-//	copy of this software and associated documentation files (the "Software"),
-//	to deal in the Software without restriction, including without limitation
-//	the rights to use, copy, modify, merge, publish, distribute, sublicense,
-//	and/or sell copies of the Software, and to permit persons to whom the
-//	Software is furnished to do so, subject to the following conditions:
-//
-//	The above copyright notice and this permission notice shall be included in
-//	all copies or substantial portions of the Software.
-//
-//	THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
-//	IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
-//	FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
-//	AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
-//	LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
-//	FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
-//	DEALINGS IN THE SOFTWARE.
-//
-//	File Name:		AutoDeleter.h
-//	Author(s):		Ingo Weinhold ([email protected])
-//	Description:	Scope-based automatic deletion of objects/arrays.
-//					ObjectDeleter - deletes an object
-//					ArrayDeleter  - deletes an array
-//					MemoryDeleter - free()s malloc()ed memory
-//------------------------------------------------------------------------------
-
 #ifndef _AUTO_DELETER_H
 #define _AUTO_DELETER_H
 
+/*!	Scope-based automatic deletion of objects/arrays.
+	ObjectDeleter - deletes an object
+	ArrayDeleter  - deletes an array
+	MemoryDeleter - free()s malloc()ed memory
+*/
+
 #include <stdlib.h>
 
 namespace BPrivate {

headers/private/shared/Referenceable.h

@@ -1,24 +1,29 @@
-/* 
+/*
- * Copyright 2005, Ingo Weinhold, bonefish@users.sf.net. All rights reserved.
+ * Copyright 2004-2007, Ingo Weinhold, bonefish@users.sf.net. All rights reserved.
  * Distributed under the terms of the MIT License.
  */
+#ifndef _REFERENCEABLE_H
+#define _REFERENCEABLE_H
 
-#ifndef REFERENCABLE_H
-#define REFERENCABLE_H
 
 #include <SupportDefs.h>
 
-// Referenceable
+
+namespace BPrivate {
+
 class Referenceable {
 public:
 								Referenceable(
-									bool deleteWhenUnreferenced = false);
+									bool deleteWhenUnreferenced = true);
 	virtual						~Referenceable();
 
-			void				AddReference();
+			void				AddReference()
+									{ atomic_add(&fReferenceCount, 1); }
+
 			bool				RemoveReference();	// returns true after last
 
-			int32				CountReferences() const;
+			int32				CountReferences() const
+									{ return fReferenceCount; }
 
 protected:
 			vint32				fReferenceCount;
@@ -26,7 +31,7 @@ protected:
 };
 
 // Reference
-template<typename Type>
+template<typename Type = BPrivate::Referenceable>
 class Reference {
 public:
 	Reference()
@@ -109,4 +114,9 @@ private:
 	Type*	fObject;
 };
 
-#endif	// REFERENCABLE_H
+}	// namespace BPrivate
+
+using BPrivate::Referenceable;
+using BPrivate::Reference;
+
+#endif	// _REFERENCEABLE_H

src/kits/support/Jamfile

@@ -22,6 +22,7 @@ MergeObject <libbe>support_kit.o :
 	List.cpp
 	Locker.cpp
 	PointerList.cpp
+	Referenceable.cpp
 	StopWatch.cpp
 	String.cpp
 #	StreamIO.cpp

src/kits/support/Referenceable.cpp

@@ -1,10 +1,11 @@
-/* 
+/*
- * Copyright 2005, Ingo Weinhold, bonefish@users.sf.net. All rights reserved.
+ * Copyright 2005-2007, Ingo Weinhold, bonefish@users.sf.net. All rights reserved.
  * Distributed under the terms of the MIT License.
  */
 
-#include "Debug.h"
+
-#include "Referenceable.h"
+#include <Referenceable.h>
+
 
 // constructor
 Referenceable::Referenceable(bool deleteWhenUnreferenced)
@@ -18,13 +19,6 @@ Referenceable::~Referenceable()
 {
 }
 
-// AddReference
-void
-Referenceable::AddReference()
-{
-	atomic_add(&fReferenceCount, 1);
-}
-
 // RemoveReference
 bool
 Referenceable::RemoveReference()
@@ -34,11 +28,3 @@ Referenceable::RemoveReference()
 		delete this;
 	return unreferenced;
 }
-
-// CountReferences
-int32
-Referenceable::CountReferences() const
-{
-	return fReferenceCount;
-}
-

src/servers/registrar/Jamfile

@@ -25,7 +25,6 @@ Server registrar
 	PriorityMessageQueue.cpp
 	RecentApps.cpp
 	RecentEntries.cpp
-	Referenceable.cpp
 	Registrar.cpp
 	RosterAppInfo.cpp
 	RosterSettingsCharStream.cpp