From 296120e005ab57970d8eb9979e9e42c974c4978c Mon Sep 17 00:00:00 2001 From: Murai Takashi Date: Sat, 4 Aug 2018 09:15:13 +0900 Subject: [PATCH] MediaPlayer: Fix -Werror=format-truncation= Increase size of text[], since snprintf() write to it max 66 bytes. (sizeof(positionText)-1 + sizeof(" / ") + sizeof(durationText)-1 + 1 = 66) Pointed out by gcc8. Change-Id: Ic6ce221edb4ceff4b63c7b30d26c52d613cbb35e Reviewed-on: https://review.haiku-os.org/779 Reviewed-by: Adrien Destugues --- src/apps/mediaplayer/interface/PositionToolTip.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/apps/mediaplayer/interface/PositionToolTip.cpp b/src/apps/mediaplayer/interface/PositionToolTip.cpp index 698727ba70..f650c79996 100644 --- a/src/apps/mediaplayer/interface/PositionToolTip.cpp +++ b/src/apps/mediaplayer/interface/PositionToolTip.cpp @@ -57,7 +57,7 @@ public: char durationText[32]; duration_to_string(fDuration, durationText, sizeof(durationText)); - char text[64]; + char text[66]; snprintf(text, sizeof(text), "%s / %s", positionText, durationText); SetText(text);