From 2a6c54fb472a9e6faf7ca979163c9ddb67f4b132 Mon Sep 17 00:00:00 2001 From: Rene Gollent Date: Sun, 2 Nov 2014 08:15:30 -0500 Subject: [PATCH] Debugger: Slight tweak to changed value highlighting. VariablesView::ModelNode: - Only check if a variable's value has changed if we actually have a valid previous value to compare against. Otherwise, e.g. variables that just came into scope but haven't yet been initialized would show up as changed, while their value is, at that point completely uninteresting. --- .../user_interface/gui/team_window/VariablesView.cpp | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/apps/debugger/user_interface/gui/team_window/VariablesView.cpp b/src/apps/debugger/user_interface/gui/team_window/VariablesView.cpp index 1c8455cfb2..78943fd7c5 100644 --- a/src/apps/debugger/user_interface/gui/team_window/VariablesView.cpp +++ b/src/apps/debugger/user_interface/gui/team_window/VariablesView.cpp @@ -354,9 +354,8 @@ private: private: void _CompareValues() { - if (fValue == NULL) - fValueChanged = false; - else { + fValueChanged = false; + if (fValue != NULL && fPreviousValue.Type() != 0) { BVariant newValue; fValue->ToVariant(newValue); fValueChanged = (fPreviousValue != newValue);