From 2b4c59635fc6ac5e3551d1f154141ff72b3b2fc7 Mon Sep 17 00:00:00 2001 From: Adrien Destugues Date: Sat, 9 May 2020 20:44:54 +0200 Subject: [PATCH] Appearance: add some extra margin around menufield labels The font antialiasing settings make the font rendering change. It can make strings longer or shorter, and this can result in the menufield being moved by a few pixels. So add a safe margin around the menu field to accomodate for it. Fixes #13039. Change-Id: I73de08b747dc8cade58bcc674dd4f94fb6a9f9eb Reviewed-on: https://review.haiku-os.org/c/haiku/+/2630 Reviewed-by: waddlesplash --- .../appearance/AntialiasingSettingsView.cpp | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/src/preferences/appearance/AntialiasingSettingsView.cpp b/src/preferences/appearance/AntialiasingSettingsView.cpp index 841f8881aa..b3b4f881c6 100644 --- a/src/preferences/appearance/AntialiasingSettingsView.cpp +++ b/src/preferences/appearance/AntialiasingSettingsView.cpp @@ -104,17 +104,17 @@ AntialiasingSettingsView::AntialiasingSettingsView(const char* name) BLayoutBuilder::Grid<>(this, B_USE_DEFAULT_SPACING, B_USE_DEFAULT_SPACING) // controls pane - .Add(fHintingMenuField->CreateLabelLayoutItem(), 0, 0) - .Add(fHintingMenuField->CreateMenuBarLayoutItem(), 1, 0) + .AddMenuField(fHintingMenuField, 0, 0) + .AddMenuField(fAntialiasingMenuField, 0, 1) + .Add(fAverageWeightControl, 0, 2, 3) - .Add(fAntialiasingMenuField->CreateLabelLayoutItem(), 0, 1) - .Add(fAntialiasingMenuField->CreateMenuBarLayoutItem(), 1, 1) - - .Add(fAverageWeightControl, 0, 2, 2) - - .AddGlue(0, 4) + .AddGlue(0, 3) .SetInsets(B_USE_WINDOW_SPACING); + BGridLayout* layout = dynamic_cast(GetLayout()); + layout->SetMinColumnWidth(0, + StringWidth(B_TRANSLATE("Antialiasing type:")) * 2); + _SetCurrentAntialiasing(); _SetCurrentHinting(); _SetCurrentAverageWeight();