From 2bffaa64ddc275e13d6afa7b035e75eccd812504 Mon Sep 17 00:00:00 2001 From: Fredrik Holmqvist Date: Tue, 15 Aug 2023 20:06:14 +0200 Subject: [PATCH] null check fTeam in CoreDumper::Dump() gcc warns "writing 4 bytes into a region of size 0" on ARM64 (-march=armv8.1-a -mno-outline-atomics) if it thinks fTeam can be null in atomic_or. Change-Id: I44c88dadf0cee6e3e54d2baaf0453ae70aa1f3c1 Reviewed-on: https://review.haiku-os.org/c/haiku/+/6838 Reviewed-by: Niels Sascha Reedijk Tested-by: Commit checker robot --- src/system/kernel/debug/core_dump.cpp | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/system/kernel/debug/core_dump.cpp b/src/system/kernel/debug/core_dump.cpp index 11536c81b4..018d94d7ff 100644 --- a/src/system/kernel/debug/core_dump.cpp +++ b/src/system/kernel/debug/core_dump.cpp @@ -777,6 +777,11 @@ struct CoreDumper { status_t Dump(const char* path, bool killTeam) { + // gcc thinks fTeam may be null in atomic_or + // and warn which causes error on some configs + if (fTeam == NULL) + return B_ERROR; + // the path must be absolute if (path[0] != '/') return B_BAD_VALUE;