i2p/haiku-beta6
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Debug Kit: Restore support for symbol lookup by remote memory access.

Browse Source 
It's been broken since clone_area was changed to block cloning of
areas without B_CLONEABLE_AREA set on them. We here introduce a
B_DEBUG_MESSAGE_CLONE_AREA debug nub message, which clones the areas
of the debugged team for the debugger.

Also fix some bugs in SymbolLookup::_FindLoadedImageAt methods:
they didn't work properly when *next was NULL, so they would
always fail when iterating over the full list.

Note that this technically breaks libdebug.so and the debugger
protocol ABI. However, nothing out-of-tree that I know of uses
the private libdebug.so, and while GDB does use the debugger
protocol, it doesn't actually use any of the messages past
the first block, so it should still work after this.

Fixes #15251.

Change-Id: I71ccbee4afd17dae30d5dacbc7590d1e2175a90e
Reviewed-on: https://review.haiku-os.org/c/haiku/+/8821
Tested-by: Commit checker robot <[email protected]>
Reviewed-by: waddlesplash <[email protected]>
This commit is contained in:
Augustin Cavalier
2025-01-13 18:03:52 +00:00
committed by waddlesplash
parent 7105c3f66d
commit 2c9560581b
9 changed files with 134 additions and 41 deletions
Download Patch File Download Diff File Expand all files Collapse all files
headers/private/debug/debug_support.h
+1 -1
View File
@@ -62,7 +62,7 @@ status_t debug_get_stack_frame(debug_context *context,
typedef struct debug_symbol_lookup_context debug_symbol_lookup_context;
typedef struct debug_symbol_iterator debug_symbol_iterator;
status_t debug_create_symbol_lookup_context(team_id team, image_id image,
status_t debug_create_symbol_lookup_context(debug_context *context, image_id image,
debug_symbol_lookup_context **lookupContext);
// imageID can be -1 if all images in the target team are
// desired, otherwise a valid image id is expected.