From 2e71ef292f09548381048d1c79e7e3172e72667c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Axel=20D=C3=B6rfler?= Date: Sat, 27 Dec 2008 20:41:06 +0000 Subject: [PATCH] * Minor cleanup, removed TODO that doesn't make much sense. git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@28824 a95241bf-73f2-0310-859d-f6bbb57e9c96 --- src/add-ons/kernel/network/stack/link.cpp | 18 +++++++++++------- 1 file changed, 11 insertions(+), 7 deletions(-) diff --git a/src/add-ons/kernel/network/stack/link.cpp b/src/add-ons/kernel/network/stack/link.cpp index 7d6a6aca64..b8a404ebf8 100644 --- a/src/add-ons/kernel/network/stack/link.cpp +++ b/src/add-ons/kernel/network/stack/link.cpp @@ -6,6 +6,7 @@ * Axel Dörfler, axeld@pinc-software.de */ +//! The net_protocol you talk to when using the AF_LINK protocol #include "datalink.h" #include "domains.h" @@ -52,7 +53,8 @@ private: net_device_monitor fMonitor; net_device_interface *fMonitoredDevice; - static status_t _MonitorData(net_device_monitor *monitor, net_buffer *buffer); + static status_t _MonitorData(net_device_monitor *monitor, + net_buffer *buffer); static void _MonitorEvent(net_device_monitor *monitor, int32 event); }; @@ -224,8 +226,6 @@ link_control(net_protocol *_protocol, int level, int option, void *value, { LinkProtocol *protocol = (LinkProtocol *)_protocol; - // TODO All of this common functionality should be elsewhere - switch (option) { case SIOCGIFINDEX: { @@ -234,7 +234,8 @@ link_control(net_protocol *_protocol, int level, int option, void *value, if (user_memcpy(&request, value, IF_NAMESIZE) < B_OK) return B_BAD_ADDRESS; - net_device_interface *interface = get_device_interface(request.ifr_name); + net_device_interface *interface + = get_device_interface(request.ifr_name); if (interface != NULL) { request.ifr_index = interface->device->index; put_device_interface(interface); @@ -250,7 +251,8 @@ link_control(net_protocol *_protocol, int level, int option, void *value, if (user_memcpy(&request, value, sizeof(struct ifreq)) < B_OK) return B_BAD_ADDRESS; - net_device_interface *interface = get_device_interface(request.ifr_index); + net_device_interface *interface + = get_device_interface(request.ifr_index); if (interface != NULL) { strlcpy(request.ifr_name, interface->device->name, IF_NAMESIZE); put_device_interface(interface); @@ -291,7 +293,8 @@ link_control(net_protocol *_protocol, int level, int option, void *value, if (user_memcpy(&request, value, IF_NAMESIZE) < B_OK) return B_BAD_ADDRESS; - net_device_interface *interface = get_device_interface(request.ifr_name); + net_device_interface *interface + = get_device_interface(request.ifr_name); if (interface != NULL) { get_device_interface_address(interface, &request.ifr_addr); put_device_interface(interface); @@ -473,7 +476,8 @@ link_std_ops(int32 op, ...) void link_init() { - register_domain_protocols(AF_LINK, SOCK_DGRAM, 0, "network/stack/link/v1", NULL); + register_domain_protocols(AF_LINK, SOCK_DGRAM, 0, "network/stack/link/v1", + NULL); register_domain_datalink_protocols(AF_LINK, IFT_ETHER, "network/datalink_protocols/ethernet_frame/v1",