i2p/haiku-beta6
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Make sure kernel breakpoints are installed on all CPUs.

Browse Source 
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@30209 a95241bf-73f2-0310-859d-f6bbb57e9c96
This commit is contained in:
Ingo Weinhold
2009-04-16 21:57:52 +00:00
parent 48b0c6f93a
commit 31d9352ff6
1 changed files with 22 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/system/kernel/arch/x86/arch_user_debugger.cpp
+22 -6
View File
@@ -212,6 +212,20 @@ clear_breakpoint(void *address, bool watchpoint)
#if KERNEL_BREAKPOINTS #if KERNEL_BREAKPOINTS
static void
install_breakpoints_per_cpu(void* /*cookie*/, int cpu)
{
struct team* kernelTeam = team_get_kernel_team();
GRAB_TEAM_DEBUG_INFO_LOCK(kernelTeam->debug_info);
install_breakpoints(kernelTeam->debug_info.arch_info);
RELEASE_TEAM_DEBUG_INFO_LOCK(kernelTeam->debug_info);
}
static status_t static status_t
set_kernel_breakpoint(void *address, uint32 type, uint32 length) set_kernel_breakpoint(void *address, uint32 type, uint32 length)
{ {
@@ -226,9 +240,10 @@ set_kernel_breakpoint(void *address, uint32 type, uint32 length)
status_t error = set_breakpoint(kernelTeam->debug_info.arch_info, address, status_t error = set_breakpoint(kernelTeam->debug_info.arch_info, address,
type, length, true); type, length, true);
install_breakpoints(kernelTeam->debug_info.arch_info);
RELEASE_TEAM_DEBUG_INFO_LOCK(kernelTeam->debug_info); RELEASE_TEAM_DEBUG_INFO_LOCK(kernelTeam->debug_info);
call_all_cpus(install_breakpoints_per_cpu, NULL);
restore_interrupts(state); restore_interrupts(state);
return error; return error;
@@ -249,9 +264,10 @@ clear_kernel_breakpoint(void *address, bool watchpoint)
status_t error = clear_breakpoint(kernelTeam->debug_info.arch_info, status_t error = clear_breakpoint(kernelTeam->debug_info.arch_info,
address, watchpoint); address, watchpoint);
install_breakpoints(kernelTeam->debug_info.arch_info);
RELEASE_TEAM_DEBUG_INFO_LOCK(kernelTeam->debug_info); RELEASE_TEAM_DEBUG_INFO_LOCK(kernelTeam->debug_info);
call_all_cpus(install_breakpoints_per_cpu, NULL);
restore_interrupts(state); restore_interrupts(state);
return error; return error;
@@ -404,7 +420,7 @@ debugger_breakpoint(int argc, char** argv)
} }
if (error == B_OK) if (error == B_OK)
install_breakpoints(info); call_all_cpus_sync(install_breakpoints_per_cpu, NULL);
else else
kprintf("Failed to install breakpoint: %s\n", strerror(error)); kprintf("Failed to install breakpoint: %s\n", strerror(error));
@@ -467,7 +483,7 @@ debugger_watchpoint(int argc, char** argv)
} }
if (error == B_OK) if (error == B_OK)
install_breakpoints(info); call_all_cpus_sync(install_breakpoints_per_cpu, NULL);
else else
kprintf("Failed to install breakpoint: %s\n", strerror(error)); kprintf("Failed to install breakpoint: %s\n", strerror(error));