From 346d1496945dfc7395581ffa1f639f8053b55ba0 Mon Sep 17 00:00:00 2001 From: Humdinger Date: Sun, 5 Nov 2017 18:38:59 +0100 Subject: [PATCH] Properly terminate property_info lists BListView's property_info list lacked termination, resulting in garbage output at the and of 'hey getsuites'. Use { 0 } everywhere for sake of consistency. Thanks to waddlesplash for spotting the bug an providing the easy fix. --- src/kits/interface/Control.cpp | 3 ++- src/kits/interface/ListView.cpp | 2 ++ src/kits/interface/Menu.cpp | 2 +- src/kits/interface/Shelf.cpp | 4 ++-- src/kits/interface/StringView.cpp | 3 ++- src/kits/interface/TabView.cpp | 2 +- src/kits/interface/TextControl.cpp | 3 ++- src/kits/interface/TextView.cpp | 1 + src/kits/interface/View.cpp | 2 +- src/kits/interface/Window.cpp | 4 ++-- 10 files changed, 16 insertions(+), 10 deletions(-) diff --git a/src/kits/interface/Control.cpp b/src/kits/interface/Control.cpp index 3009da4593..6b3dbe8e56 100644 --- a/src/kits/interface/Control.cpp +++ b/src/kits/interface/Control.cpp @@ -44,7 +44,8 @@ static property_info sPropertyList[] = { NULL, 0, { B_INT32_TYPE } }, - {} + + {0} }; diff --git a/src/kits/interface/ListView.cpp b/src/kits/interface/ListView.cpp index dcb0746643..fcd870195b 100644 --- a/src/kits/interface/ListView.cpp +++ b/src/kits/interface/ListView.cpp @@ -78,6 +78,8 @@ static property_info sProperties[] = { "Select or deselect all items in the selection. Boolean field \"data\" " "chooses selection or deselection.", 0, { B_BOOL_TYPE } }, + + { 0 } }; diff --git a/src/kits/interface/Menu.cpp b/src/kits/interface/Menu.cpp index d7c9d39e3b..98b1054927 100644 --- a/src/kits/interface/Menu.cpp +++ b/src/kits/interface/Menu.cpp @@ -195,7 +195,7 @@ static property_info sPropList[] = { "current specifier off the stack." }, - {} + { 0 } }; diff --git a/src/kits/interface/Shelf.cpp b/src/kits/interface/Shelf.cpp index 5aa9671268..070c0566f8 100644 --- a/src/kits/interface/Shelf.cpp +++ b/src/kits/interface/Shelf.cpp @@ -115,7 +115,7 @@ static property_info sShelfPropertyList[] = { "... of Replicant {index | name | id} of ...", 0, }, - { 0, { 0 }, { 0 }, 0, 0 } + { 0 } }; static property_info sReplicantPropertyList[] = { @@ -154,7 +154,7 @@ static property_info sReplicantPropertyList[] = { NULL, 0, }, - { 0, { 0 }, { 0 }, 0, 0 } + { 0 } }; diff --git a/src/kits/interface/StringView.cpp b/src/kits/interface/StringView.cpp index 6f39ebd408..1f38c6896d 100644 --- a/src/kits/interface/StringView.cpp +++ b/src/kits/interface/StringView.cpp @@ -43,7 +43,8 @@ static property_info sPropertyList[] = { NULL, 0, { B_INT32_TYPE } }, - {} + + { 0 } }; diff --git a/src/kits/interface/TabView.cpp b/src/kits/interface/TabView.cpp index d1762edd03..ce5f648a8e 100644 --- a/src/kits/interface/TabView.cpp +++ b/src/kits/interface/TabView.cpp @@ -42,7 +42,7 @@ static property_info sPropertyList[] = { { B_INT32_TYPE } }, - {} + { 0 } }; diff --git a/src/kits/interface/TextControl.cpp b/src/kits/interface/TextControl.cpp index 16b528f684..a6a88049a2 100644 --- a/src/kits/interface/TextControl.cpp +++ b/src/kits/interface/TextControl.cpp @@ -61,7 +61,8 @@ static property_info sPropertyList[] = { NULL, 0, { B_STRING_TYPE } }, - {} + + { 0 } }; diff --git a/src/kits/interface/TextView.cpp b/src/kits/interface/TextView.cpp index e824a5433b..765bc5ffcb 100644 --- a/src/kits/interface/TextView.cpp +++ b/src/kits/interface/TextView.cpp @@ -251,6 +251,7 @@ static property_info sPropertyList[] = { "BTextView.", 0, { B_RAW_TYPE, 0 }, }, + { 0 } }; diff --git a/src/kits/interface/View.cpp b/src/kits/interface/View.cpp index 8f164a6987..9674a24e42 100644 --- a/src/kits/interface/View.cpp +++ b/src/kits/interface/View.cpp @@ -99,7 +99,7 @@ static property_info sViewPropInfo[] = { "Directs the scripting message to the specified view.", 0 }, - { 0, { 0 }, { 0 }, 0, 0 } + { 0 } }; diff --git a/src/kits/interface/Window.cpp b/src/kits/interface/Window.cpp index ddc072cd09..5f3a284fea 100644 --- a/src/kits/interface/Window.cpp +++ b/src/kits/interface/Window.cpp @@ -183,7 +183,7 @@ static property_info sWindowPropInfo[] = { { B_DIRECT_SPECIFIER }, NULL, 0, { B_RECT_TYPE } }, - {} + { 0 } }; static value_info sWindowValueInfo[] = { @@ -207,7 +207,7 @@ static value_info sWindowValueInfo[] = { "Resize by the offsets in the BPoint data" }, - {} + { 0 } };