From 36bf86d2b6114bd2a21ca4edaf7b996921c5da44 Mon Sep 17 00:00:00 2001 From: Murai Takashi Date: Sat, 21 Sep 2019 16:02:29 +0900 Subject: [PATCH] Pulse: Fix 'new[]' array freed with 'delete' MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit cpu_menu_items is allocated by new[] in Init(), but freed by delete. Pointed out by LGTM. Change-Id: I4cc669c519cc4ea3e170cb9f421d6b4ff77df8a2 Reviewed-on: https://review.haiku-os.org/c/haiku/+/1881 Reviewed-by: Axel Dörfler --- src/apps/pulse/PulseView.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/apps/pulse/PulseView.cpp b/src/apps/pulse/PulseView.cpp index a5e7a85382..857c552284 100644 --- a/src/apps/pulse/PulseView.cpp +++ b/src/apps/pulse/PulseView.cpp @@ -158,7 +158,7 @@ void PulseView::ChangeCPUState(BMessage *message) { PulseView::~PulseView() { if (popupmenu != NULL) delete popupmenu; - if (cpu_menu_items != NULL) delete cpu_menu_items; + if (cpu_menu_items != NULL) delete[] cpu_menu_items; delete[] prev_active; delete[] cpu_times;