i2p/haiku-beta6
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

ICNSTranslator: Fix same expression used in consecutive assignments

Browse Source 
Fix same expression (imageTypeInfo.iconWidth) is used in consecutive
assignments of 'iconWidth' and 'iconHeight' at line 191, 192.
Pointed out by cppcheck.

Change-Id: I251a4b8e6c83f86aad4fa0030ebc362f3b97fb0e
Reviewed-on: https://review.haiku-os.org/c/haiku/+/3499
Reviewed-by: Jérôme Duval <[email protected]>
This commit is contained in:
Murai Takashi
2020-12-12 13:54:12 +00:00
committed by Adrien Destugues
parent c3427db750
commit 37cd311852
1 changed files with 46 additions and 46 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/add-ons/translators/icns/ICNSLoader.cpp
+1 -1
View File
@@ -189,7 +189,7 @@ ICNSSaver::ICNSSaver(BPositionIO *stream, uint32 rowBytes, icns_type_t type)
icns_icon_info_t imageTypeInfo = icns_get_image_info_for_type(type); icns_icon_info_t imageTypeInfo = icns_get_image_info_for_type(type);
int iconWidth = imageTypeInfo.iconWidth; int iconWidth = imageTypeInfo.iconWidth;
int iconHeight = imageTypeInfo.iconWidth; int iconHeight = imageTypeInfo.iconHeight;
int bpp = 32; int bpp = 32;
uint8 *bits = new uint8[iconWidth * iconHeight * sizeof(uint32)]; uint8 *bits = new uint8[iconWidth * iconHeight * sizeof(uint32)];