From 37e6de5d4c6ba2b27884fdb8385efbdbf8ecf34c Mon Sep 17 00:00:00 2001 From: Ingo Weinhold Date: Thu, 1 Oct 2009 04:38:19 +0000 Subject: [PATCH] Don't destroy tracing entries. This is not necessary and even harmful, if the code is no longer loaded, e.g. when the module has been unloaded or the tracing buffer was reattached from a previous session. git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@33389 a95241bf-73f2-0310-859d-f6bbb57e9c96 --- src/system/kernel/debug/tracing.cpp | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/system/kernel/debug/tracing.cpp b/src/system/kernel/debug/tracing.cpp index 310eed36ed..09369ded7f 100644 --- a/src/system/kernel/debug/tracing.cpp +++ b/src/system/kernel/debug/tracing.cpp @@ -253,8 +253,9 @@ TracingMetaData::_FreeFirstEntry() if (fFirstEntry->flags & BUFFER_ENTRY) { // a buffer entry -- just skip it } else if (fFirstEntry->flags & ENTRY_INITIALIZED) { - // fully initialized TraceEntry -- destroy it - TraceEntry::FromTraceEntry(fFirstEntry)->~TraceEntry(); + // Fully initialized TraceEntry: We could destroy it, but don't do so + // for sake of robustness. The destructors of tracing entry classes + // should be empty anyway. fEntries--; } else { // Not fully initialized TraceEntry. We can't free it, since