Enable -fvisibility=hidden on static libraries by default.

Only on non-GCC2 for now, as GCC2 does not have -fvisibility.

An opt-out is left as a possibility, and is unfortunately necessary
for libshared and libicon, as these two are used even in WebKit instead
of linking to the .a. However, libcolumnlistview, libagg, and a whole
bunch of others are now no longer exported, so this is already a major
improvement on what symbols we were leaking.

This may provide performance differences for consumers of these APIs,
as GCC and the linker are now free to merge and directly use functions
that previously could have been semantically interposed. AGG usage in
app_server, especially, may benefit.

We can also now remove the addition from libnetservices, so do that.

build/jam/MainBuildRules

@@ -154,6 +154,12 @@ rule StaticLibrary
 
 	InheritPlatform $(objects) : $(lib) ;
 
+	if $(TARGET_CC_IS_LEGACY_GCC_$(TARGET_PACKAGING_ARCH)) = 0
+			&& [ on $(lib) return $(NO_HIDDEN_VISIBILITY) ] != 1 {
+		CCFLAGS on $(objects) += -fvisibility=hidden ;
+		C++FLAGS on $(objects) += -fvisibility=hidden ;
+	}
+
 	StaticLibraryFromObjects $(lib) : $(objects) $(otherObjects) ;
 	Objects $(2) ;
 }

src/build/libroot/Jamfile

@@ -92,6 +92,7 @@ BuildPlatformStaticLibrary libroot_build.a :
 
 USES_BE_API on [ FGristFiles function_remapper$(SUFOBJ) ] = true ;
 
+NO_HIDDEN_VISIBILITY on <build>libroot_build_function_remapper.a = 1 ;
 BuildPlatformStaticLibraryPIC libroot_build_function_remapper.a :
 	function_remapper.cpp
 ;

src/kits/network/libnetservices/JamCommon

@@ -54,13 +54,6 @@ for architectureObject in [ MultiArchSubDirSetup ] {
 				: <$(architecture)>libshared.a
 				;
 		} else {
-			if $(HAIKU_CC_IS_LEGACY_GCC_$(architecture)) = 0 {
-				# In order to not have conflicts between libraries built against
-				# different versions of libnetservices.a, prevent symbols from
-				# being re-exported from the static library.
-				SubDirC++Flags -fvisibility=hidden ;
-			}
-
 			StaticLibrary [ MultiArchDefaultGristFiles libnetservices.a ] :
 				$(sources)
 				Geolocation.cpp

src/kits/shared/Jamfile

@@ -24,6 +24,10 @@ for architectureObject in [ MultiArchSubDirSetup ] {
 		# for BKeymap
 		UsePrivateHeaders interface ;
 
+		# FIXME: These symbols should be hidden, but too many applications depend
+		# on them at present for that.
+		NO_HIDDEN_VISIBILITY on <$(architecture)>libshared.a = 1 ;
+
 		StaticLibrary <$(architecture)>libshared.a :
 			AboutMenuItem.cpp
 			ArgumentVector.cpp

src/libs/icon/Jamfile

@@ -20,12 +20,18 @@ UsePrivateHeaders shared ;
 local architectureObject ;
 for architectureObject in [ MultiArchSubDirSetup ] {
 	on $(architectureObject) {
+		local architecture = $(TARGET_PACKAGING_ARCH) ;
+
 		local sourceDir ;
 		for sourceDir in $(sourceDirs) {
 			SEARCH_SOURCE
 				+= [ FDirName $(HAIKU_TOP) src libs icon $(sourceDir) ] ;
 		}
 
+		# Too many applications depend on libicon APIs being visible in libbe;
+		# so for now, prevent -fvisiblity=hidden from being set.
+		NO_HIDDEN_VISIBILITY on [ MultiArchDefaultGristFiles libicon.a ] = 1 ;
+
 		StaticLibrary [ MultiArchDefaultGristFiles libicon.a ] :
 			# flat_icon
 			FlatIconFormat.cpp

src/servers/app/drawing/Jamfile

@@ -15,6 +15,8 @@ UseBuildFeatureHeaders freetype ;
 Includes [ FGristFiles AlphaMask.cpp AlphaMaskCache.cpp DrawingEngine.cpp ]
 	: [ BuildFeatureAttribute freetype : headers ] ;
 
+NO_HIDDEN_VISIBILITY on libasdrawing.a = 1 ;
+
 StaticLibrary libasdrawing.a :
 	AlphaMask.cpp
 	AlphaMaskCache.cpp

src/servers/app/stackandtile/Jamfile

@@ -23,6 +23,8 @@ local sources =
 Includes [ FGristFiles $(sources) ]
 	: [ BuildFeatureAttribute freetype : headers ] ;
 
+NO_HIDDEN_VISIBILITY on libstackandtile.a = 1 ;
+
 StaticLibrary libstackandtile.a :
 	$(sources)
 ;