i2p/haiku-beta6
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Using the buffer of the string instead of one on the stack.

Browse Source 
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@40726 a95241bf-73f2-0310-859d-f6bbb57e9c96
This commit is contained in:
Jonas Sundström
2011-02-27 15:19:54 +00:00
parent e5d0372ce3
commit 3838fb9359
1 changed files with 4 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/kits/support/String.cpp
+4 -10
View File
@@ -427,20 +427,14 @@ BString::AdoptChars(BString& string, int32 charCount)
BString& BString&
BString::SetToArguments(const char* format, ...) BString::SetToArguments(const char* format, ...)
{ {
int32 bufferSize = 128;
char buffer[bufferSize];
va_list arg; va_list arg;
va_start(arg, format); va_start(arg, format);
int32 bytes = vsnprintf(buffer, bufferSize, format, arg); int32 bytes = vsnprintf(LockBuffer(0), Length() + 1, format, arg);
va_end(arg); va_end(arg);
if (bytes < 0) { if (bytes <= Length()) {
return *this; bytes = bytes < 0 ? 0 : bytes;
} UnlockBuffer(bytes);
if (bytes < bufferSize) {
SetTo(buffer);
} else { } else {
va_list arg2; va_list arg2;
va_start(arg2, format); va_start(arg2, format);