From 390b0f9486710ea54637b517b81a5ce39b81c0fc Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Stephan=20A=C3=9Fmus?= Date: Tue, 28 Jul 2009 21:22:54 +0000 Subject: [PATCH] Added TODO about why the implementation of StoreConfiguratoin() is broken if it were ever called for an inactive workspace, as our BScreen API in theory allows you to do (not the BeOS API). git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@31863 a95241bf-73f2-0310-859d-f6bbb57e9c96 --- src/servers/app/Desktop.cpp | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/servers/app/Desktop.cpp b/src/servers/app/Desktop.cpp index 6e1dab6637..98d7a866ac 100644 --- a/src/servers/app/Desktop.cpp +++ b/src/servers/app/Desktop.cpp @@ -1161,6 +1161,10 @@ Desktop::ScreenChanged(Screen* screen, bool makeDefault) status_t Desktop::StoreConfiguration(int32 workspace) { + // TODO: This only works because StoreConfiguration is never called + // for an inactive workspace. fVirtualScreen has the screen mode + // of the current workspace. + if (workspace >= 0 && workspace < fSettings->WorkspacesCount()) { // store settings BMessage settings;