From 39a1e74b081582fd8d320347496f61dca43aaf10 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Dariusz=20Knoci=C5=84ski?= Date: Wed, 26 Mar 2014 16:53:42 -0400 Subject: [PATCH] Time Preferences crashes with empty selection Application "Time" crashes when you push "Remove" button without any selection on list of network time servers. Fixes #10716 Please use git format-patch to create your patches in the future so that the author information is preserved. Signed-off-by: John Scipione --- src/preferences/time/NetworkTimeView.cpp | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/src/preferences/time/NetworkTimeView.cpp b/src/preferences/time/NetworkTimeView.cpp index c0dbfc5523..1f804776b6 100644 --- a/src/preferences/time/NetworkTimeView.cpp +++ b/src/preferences/time/NetworkTimeView.cpp @@ -308,13 +308,17 @@ NetworkTimeView::MessageReceived(BMessage* message) break; case kMsgRemoveServer: + { + int32 currentSelection = fServerListView->CurrentSelection(); + if (currentSelection < 0) + break; + fSettings.RemoveServer(((BStringItem*) - fServerListView->ItemAt( - fServerListView-> - CurrentSelection()))->Text()); + fServerListView->ItemAt(currentSelection))->Text()); _UpdateServerList(); Looper()->PostMessage(new BMessage(kMsgChange)); break; + } case kMsgResetServerList: fSettings.ResetServersToDefaults();