i2p/haiku-beta6
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

ATA bus_manager: return value (signed) put in unsigned variable

Browse Source 
This might have been occulting an eventual error code.

CID 4095.
This commit is contained in:
Philippe Saint-Pierre
2011-12-29 14:54:47 -05:00
parent 91a7326a04
commit 3ad5b0818e
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/add-ons/kernel/bus_managers/ata/ATAModule.cpp
+2 -2
View File
@@ -172,7 +172,7 @@ ata_channel_added(device_node *parent)
return B_ERROR; return B_ERROR;
} }
uint32 channelID = gDeviceManager->create_id(ATA_CHANNEL_ID_GENERATOR); int32 channelID = gDeviceManager->create_id(ATA_CHANNEL_ID_GENERATOR);
if (channelID < 0) { if (channelID < 0) {
TRACE_ERROR("out of channel ids\n"); TRACE_ERROR("out of channel ids\n");
return B_ERROR; return B_ERROR;
@@ -195,7 +195,7 @@ ata_channel_added(device_node *parent)
// - ATA allows up to 256 blocks for LBA28 and 65535 for LBA48 // - ATA allows up to 256 blocks for LBA28 and 65535 for LBA48
// to fix specific drive bugs use ATAChannel::GetRestrictions() // to fix specific drive bugs use ATAChannel::GetRestrictions()
{ B_DMA_MAX_TRANSFER_BLOCKS, B_UINT32_TYPE, { ui32: 0xffff } }, { B_DMA_MAX_TRANSFER_BLOCKS, B_UINT32_TYPE, { ui32: 0xffff } },
{ ATA_CHANNEL_ID_ITEM, B_UINT32_TYPE, { ui32: channelID } }, { ATA_CHANNEL_ID_ITEM, B_UINT32_TYPE, { ui32: (uint32)channelID } },
{ NULL } { NULL }
}; };