* Fixed a few problems in AddMessage() (most of them were pointed out by Marcus):

- no need to initialize the buffer on stack
  - no need to initialize "buffer" to NULL
  - renamed "buf" to stackBuffer
  - enlarged buffer on stack to 16384 bytes (we have a minimum of 192 kB of
    stack per thread, anyway).
  - check the actual size of the stack buffer against the message's flattened
    size instead of the one of its pointer.
  - check if the allocation of the helper buffer failed, and return B_NO_MEMORY
    in this case.
* Moved static helper functions to the top of the file.
* Minor cleanup.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@24204 a95241bf-73f2-0310-859d-f6bbb57e9c96

src/kits/app/Message.cpp

@@ -1,10 +1,11 @@
 /*
- * Copyright 2005-2007, Haiku Inc. All rights reserved.
+ * Copyright 2005-2008, Haiku Inc. All rights reserved.
  * Distributed under the terms of the MIT License.
  *
  * Authors:
  *		Michael Lotz <[email protected]>
  */
+
 #include <Message.h>
 #include <MessageAdapter.h>
 #include <MessagePrivate.h>
@@ -51,13 +52,13 @@ const char *B_PROPERTY_ENTRY = "property";
 const char *B_PROPERTY_NAME_ENTRY = "name";
 
 
-static status_t		handle_reply(port_id replyPort, int32 *pCode,
+static status_t	handle_reply(port_id replyPort, int32 *pCode, bigtime_t timeout,
-						bigtime_t timeout, BMessage *reply);
+	BMessage *reply);
 
 extern "C" {
-		// private os function to set the owning team of an area
+	// private os function to set the owning team of an area
-		status_t	_kern_transfer_area(area_id area, void **_address,
+	status_t _kern_transfer_area(area_id area, void **_address,
-						uint32 addressSpec, team_id target);
+		uint32 addressSpec, team_id target);
 }
 
 
@@ -66,6 +67,57 @@ port_id BMessage::sReplyPorts[sNumReplyPorts];
 long BMessage::sReplyPortInUse[sNumReplyPorts];
 
 
+template<typename Type> static uint8 *
+print_to_stream_type(uint8* pointer)
+{
+	Type *item = (Type *)pointer;
+	item->PrintToStream();
+	return (uint8 *)(item+1);
+}
+
+
+template<typename Type> static uint8 *
+print_type(const char* format, uint8* pointer)
+{
+	Type *item = (Type *)pointer;
+	printf(format, *item, *item);
+	return (uint8 *)(item+1);
+}
+
+
+static status_t
+handle_reply(port_id replyPort, int32 *_code, bigtime_t timeout,
+	BMessage *reply)
+{
+	DEBUG_FUNCTION_ENTER2;
+	ssize_t size;
+	do {
+		size = port_buffer_size_etc(replyPort, B_RELATIVE_TIMEOUT, timeout);
+	} while (size == B_INTERRUPTED);
+
+	if (size < B_OK)
+		return size;
+
+	status_t result;
+	char *buffer = (char *)malloc(size);
+	do {
+		result = read_port(replyPort, _code, buffer, size);
+	} while (result == B_INTERRUPTED);
+
+	if (result < B_OK || *_code != kPortMessageCode) {
+		free(buffer);
+		return result < B_OK ? result : B_ERROR;
+	}
+
+	result = reply->Unflatten(buffer);
+	free(buffer);
+	return result;
+}
+
+
+//	#pragma mark -
+
+
 BMessage::BMessage()
 {
 	DEBUG_FUNCTION_ENTER;
@@ -376,24 +428,6 @@ BMessage::IsReply() const
 }
 
 
-template<typename Type> static uint8 *
-print_to_stream_type(uint8* pointer)
-{
-	Type *item = (Type *)pointer;
-	item->PrintToStream();
-	return (uint8 *)(item+1);
-}
-
-
-template<typename Type> static uint8 *
-print_type(const char* format, uint8* pointer)
-{
-	Type *item = (Type *)pointer;
-	printf(format, *item, *item);
-	return (uint8 *)(item+1);
-}
-
-
 void
 BMessage::PrintToStream() const
 {
@@ -2107,36 +2141,6 @@ BMessage::_SendFlattenedMessage(void *data, int32 size, port_id port,
 }
 
 
-static status_t
-handle_reply(port_id replyPort, int32 *_code, bigtime_t timeout,
-	BMessage *reply)
-{
-	DEBUG_FUNCTION_ENTER2;
-	ssize_t size;
-	do {
-		size = port_buffer_size_etc(replyPort, B_RELATIVE_TIMEOUT, timeout);
-	} while (size == B_INTERRUPTED);
-
-	if (size < B_OK)
-		return size;
-
-	status_t result;
-	char *buffer = (char *)malloc(size);
-	do {
-		result = read_port(replyPort, _code, buffer, size);
-	} while (result == B_INTERRUPTED);
-
-	if (result < B_OK || *_code != kPortMessageCode) {
-		free(buffer);
-		return result < B_OK ? result : B_ERROR;
-	}
-
-	result = reply->Unflatten(buffer);
-	free(buffer);
-	return result;
-}
-
-
 void BMessage::_ReservedMessage1(void) {};
 void BMessage::_ReservedMessage2(void) {};
 void BMessage::_ReservedMessage3(void) {};
@@ -2300,16 +2304,18 @@ BMessage::AddMessage(const char *name, const BMessage *message)
 	copying an extra buffer. Functions can be added that return a direct
 	pointer into the message. */
 
-	char buf[4096] = { 0 };
+	char stackBuffer[16384];
 	ssize_t size = message->FlattenedSize();
 
 	bool freeBuffer = false;
-	char* buffer = NULL;
+	char* buffer;
-	if (size > (ssize_t)sizeof(buffer)) {
+	if (size > (ssize_t)sizeof(stackBuffer)) {
 		freeBuffer = true;
 		buffer = static_cast<char*>(malloc(size));
+		if (buffer == NULL)
+			return B_NO_MEMORY;
 	} else {
-		buffer = buf;
+		buffer = stackBuffer;
 	}
 
 	status_t error = message->Flatten(buffer, size);