From 3c181db6bf725805b9c08366b51507753dbda1db Mon Sep 17 00:00:00 2001 From: Augustin Cavalier Date: Wed, 20 Oct 2021 13:28:36 -0400 Subject: [PATCH] vesa & radeon_hd: Remove unneeded and incorrect free(). In 47404f12f27fc45fc0c011b1c5ac6f0c1b52e0e6, a MemoryDeleter was added to manage this memory instead of doing it manually; most of the free()s were removed in that commit, but these were somehow missed. --- src/add-ons/accelerants/radeon_hd/accelerant.cpp | 1 - src/add-ons/accelerants/vesa/accelerant.cpp | 5 +---- 2 files changed, 1 insertion(+), 5 deletions(-) diff --git a/src/add-ons/accelerants/radeon_hd/accelerant.cpp b/src/add-ons/accelerants/radeon_hd/accelerant.cpp index 4939654f31..fcd48c1a8d 100644 --- a/src/add-ons/accelerants/radeon_hd/accelerant.cpp +++ b/src/add-ons/accelerants/radeon_hd/accelerant.cpp @@ -113,7 +113,6 @@ init_common(int device, bool isClone) if (ioctl(device, RADEON_GET_PRIVATE_DATA, &data, sizeof(radeon_get_private_data)) != 0) { - free(gInfo); return B_ERROR; } diff --git a/src/add-ons/accelerants/vesa/accelerant.cpp b/src/add-ons/accelerants/vesa/accelerant.cpp index afde7f7220..4daeea8749 100644 --- a/src/add-ons/accelerants/vesa/accelerant.cpp +++ b/src/add-ons/accelerants/vesa/accelerant.cpp @@ -53,11 +53,8 @@ init_common(int device, bool isClone) // get basic info from driver area_id sharedArea; - if (ioctl(device, VESA_GET_PRIVATE_DATA, &sharedArea, sizeof(area_id)) - != 0) { - free(gInfo); + if (ioctl(device, VESA_GET_PRIVATE_DATA, &sharedArea, sizeof(area_id)) != 0) return B_ERROR; - } AreaDeleter sharedDeleter(clone_area("vesa shared info", (void **)&gInfo->shared_info, B_ANY_ADDRESS,