From 3d3b89c8cc9d4cbfbc5e8825a92550b8aca4d426 Mon Sep 17 00:00:00 2001 From: Augustin Cavalier Date: Sat, 1 Apr 2023 11:33:44 -0400 Subject: [PATCH] kernel/util: Privatize the deprecated DoublyLinkedList::Insert() variant. Removing it outright would cause implicit conversions and then the other variant being called, which would create invalid lists. So make it private so that any attempts to use it will create errors at compile-time. --- headers/private/kernel/util/DoublyLinkedList.h | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/headers/private/kernel/util/DoublyLinkedList.h b/headers/private/kernel/util/DoublyLinkedList.h index 25e6ee6427..69086e57ec 100644 --- a/headers/private/kernel/util/DoublyLinkedList.h +++ b/headers/private/kernel/util/DoublyLinkedList.h @@ -335,8 +335,6 @@ public: inline void InsertBefore(Element* insertBefore, Element* element); inline void InsertAfter(Element* insertAfter, Element* element); inline void Insert(Element* element, bool back = true); - inline void Insert(Element* before, Element* element); - // TODO: Obsolete! Use InsertBefore() instead! inline void Add(Element* element, bool back = true); inline void Remove(Element* element); @@ -377,6 +375,10 @@ public: inline ConstReverseIterator GetReverseIterator() const { return ConstReverseIterator(this); } +private: + inline void Insert(Element* before, Element* element); + // TODO: Obsolete! Use InsertBefore() instead! + private: Element* fFirst; Element* fLast;