From 4024e5b6a4a81806ebf7a53da11ea39531fc9c2d Mon Sep 17 00:00:00 2001 From: Augustin Cavalier Date: Thu, 24 Aug 2023 21:02:30 -0400 Subject: [PATCH] ramfs: Do not advertise ourselves as a persistent filesystem. The original change to fix ramfs appearance (hrev56642) in Tracker and elsewhere said the reason for adding the FS_IS_REMOVABLE flag instead of removing FS_IS_PERSISTENT was because of problems encountered with writing/deleting entries on ramfs mounts. I was unable to reproduce those problems; writing and deleting entries on RAMFS mounts still works just fine in Tracker and elsewhere, even after removing the flag. So it seems safe to remove; subsequent problems can be addressed as they come up. Fixes #18173. --- src/add-ons/kernel/file_systems/ramfs/kernel_interface.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/add-ons/kernel/file_systems/ramfs/kernel_interface.cpp b/src/add-ons/kernel/file_systems/ramfs/kernel_interface.cpp index 0a07698f06..fb93fe9c2e 100644 --- a/src/add-ons/kernel/file_systems/ramfs/kernel_interface.cpp +++ b/src/add-ons/kernel/file_systems/ramfs/kernel_interface.cpp @@ -138,8 +138,8 @@ ramfs_read_fs_info(fs_volume* _volume, struct fs_info *info) Volume* volume = (Volume*)_volume->private_volume; status_t error = B_OK; if (VolumeReadLocker locker = volume) { - info->flags = B_FS_IS_PERSISTENT | B_FS_HAS_ATTR | B_FS_HAS_MIME - | B_FS_HAS_QUERY | B_FS_IS_REMOVABLE; + info->flags = B_FS_HAS_ATTR | B_FS_HAS_MIME | B_FS_HAS_QUERY + | B_FS_IS_REMOVABLE; info->block_size = B_PAGE_SIZE; info->io_size = kOptimalIOSize; info->total_blocks = volume->CountBlocks();