i2p/haiku-beta6
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

DataTranslations: avoid layout jumping

Browse Source 
* Constrain the list and "right view" sizes so the layout doesn't change
for each translator.
* Fixes #6897.
This commit is contained in:
Adrien Destugues
2014-12-09 08:47:09 +01:00
parent 4cec648e86
commit 4380baa4d7
1 changed files with 10 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/preferences/datatranslations/DataTranslationsWindow.cpp
+10 -2
View File
@@ -1,5 +1,5 @@
/* /*
* Copyright 2002-2010, Haiku, Inc. * Copyright 2002-2014, Haiku, Inc.
* Distributed under the terms of the MIT license. * Distributed under the terms of the MIT license.
* *
* Authors: * Authors:
@@ -12,6 +12,7 @@
#include "DataTranslationsWindow.h" #include "DataTranslationsWindow.h"
#include <algorithm>
#include <stdio.h> #include <stdio.h>
#include <Alert.h> #include <Alert.h>
@@ -90,6 +91,8 @@ DataTranslationsWindow::_PopulateListView()
translator_id* translators = NULL; translator_id* translators = NULL;
roster->GetAllTranslators(&translators, &numTranslators); roster->GetAllTranslators(&translators, &numTranslators);
float maxWidth = 0;
for (int32 i = 0; i < numTranslators; i++) { for (int32 i = 0; i < numTranslators; i++) {
// Getting the first three Infos: Name, Info & Version // Getting the first three Infos: Name, Info & Version
int32 version; int32 version;
@@ -97,8 +100,11 @@ DataTranslationsWindow::_PopulateListView()
const char* info; const char* info;
roster->GetTranslatorInfo(translators[i], &name, &info, &version); roster->GetTranslatorInfo(translators[i], &name, &info, &version);
fTranslatorListView->AddItem(new TranslatorItem(translators[i], name)); fTranslatorListView->AddItem(new TranslatorItem(translators[i], name));
maxWidth = std::max(maxWidth, fTranslatorListView->StringWidth(name));
} }
fTranslatorListView->SetExplicitSize(BSize(maxWidth + 20, B_SIZE_UNSET));
delete[] translators; delete[] translators;
return B_OK; return B_OK;
} }
@@ -208,13 +214,15 @@ DataTranslationsWindow::_SetupViews()
fRightBox = new BBox("Right_Side"); fRightBox = new BBox("Right_Side");
fRightBox->SetExplicitAlignment(BAlignment(B_ALIGN_USE_FULL_WIDTH, fRightBox->SetExplicitAlignment(BAlignment(B_ALIGN_USE_FULL_WIDTH,
B_ALIGN_USE_FULL_HEIGHT)); B_ALIGN_USE_FULL_HEIGHT));
fRightBox->SetExplicitMinSize(BSize(350, 300));
// Add the translator icon view // Add the translator icon view
fIconView = new IconView(); fIconView = new IconView();
// Add the translator info button // Add the translator info button
fButton = new BButton("info", B_TRANSLATE("Info"), fButton = new BButton("info", B_TRANSLATE("Info"),
new BMessage(kMsgTranslatorInfo), B_WILL_DRAW | B_FRAME_EVENTS | B_NAVIGABLE); new BMessage(kMsgTranslatorInfo),
B_WILL_DRAW | B_FRAME_EVENTS | B_NAVIGABLE);
fButton->SetEnabled(false); fButton->SetEnabled(false);
// Populate the translators list view // Populate the translators list view