Simplify code and clean up.

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38738 a95241bf-73f2-0310-859d-f6bbb57e9c96

headers/libs/linprog/Summand.h

@@ -3,7 +3,6 @@
  * Copyright 2007-2008, James Kim, [email protected]
  * Distributed under the terms of the MIT License.
  */
-
 #ifndef	SUMMAND_H
 #define	SUMMAND_H
 
@@ -17,20 +16,19 @@ class Variable;
  * A summand of a linear term.
  */
 class Summand {
-
 public:
-	double			Coeff();
+								Summand(double coeff, Variable* var);
-	void			SetCoeff(double coeff);
+								~Summand();
-	Variable*		Var();
+
-	void			SetVar(Variable* var);
+			double				Coeff();
-					Summand(double coeff, Variable* var);
+			void				SetCoeff(double coeff);
-					~Summand();
+			Variable*			Var();
+			void				SetVar(Variable* var);
 
 private:
-	double			fCoeff;
+			double				fCoeff;
-	Variable*		fVar;
+			Variable*			fVar;
-	bool    fUsedInPenaltyFunction;  //not set yet
+			bool    			fUsedInPenaltyFunction;  //not set yet
-
 };
 
 }	// namespace LinearProgramming

headers/libs/linprog/Variable.h

@@ -7,7 +7,7 @@
 #define	VARIABLE_H
 
 #include <File.h>
-#include <List.h>
+#include <ObjectList.h>
 #include <String.h>
 #include <SupportDefs.h>
 
@@ -60,7 +60,7 @@ protected:
 
 private:
 			LinearSpec*			fLS;
-			BList*				fUsingSummands;
+			BObjectList<Summand>	fUsingSummands;
 				// All Summands that link to this Variable
 			double				fValue;
 			double				fMin;

src/libs/linprog/Jamfile

@@ -3,6 +3,7 @@ SubDir HAIKU_TOP src libs linprog ;
 SetSubDirSupportedPlatformsBeOSCompatible ;
 
 UseLibraryHeaders lp_solve linprog ;
+UsePrivateHeaders shared ;
 
 SharedLibrary liblinprog.so : 
 	Constraint.cpp

src/libs/linprog/Summand.cpp

@@ -62,7 +62,7 @@ Summand::SetVar(Variable* var)
  */
 Summand::~Summand()
 {
-  fVar->fUsingSummands->RemoveItem(this);
+  fVar->fUsingSummands.RemoveItem(this);
 }
 
 
@@ -74,7 +74,6 @@ Summand::Summand(double coeff, Variable* var)
 	fCoeff = coeff;
 	fVar = var;
 	fUsedInPenaltyFunction = false;
-	fVar->fUsingSummands->AddItem(this);
+	fVar->fUsingSummands.AddItem(this);
-	
 }
 

src/libs/linprog/Variable.cpp

@@ -97,11 +97,7 @@ Variable::Min() const
 void
 Variable::SetMin(double min)
 {
-	if (!fIsValid)
+	SetRange(min, fMax);
-		return;
-
-	fMin = min;
-	set_bounds(fLS->fLP, this->Index(), fMin, fMax);
 }
 
 
@@ -125,11 +121,7 @@ Variable::Max() const
 void
 Variable::SetMax(double max)
 {
-	if (!fIsValid)
+	SetRange(fMin, max);
-		return;
-
-	fMax = max;
-	set_bounds(fLS->fLP, this->Index(), fMin, fMax);
 }
 
 
@@ -325,8 +317,9 @@ Variable::Invalidate()
  * Constructor.
  */
 Variable::Variable(LinearSpec* ls)
-	: fLS(ls),
+	:
-	fUsingSummands(new BList()),
+	fLS(ls),
+
 	fValue(NAN),
 	fMin(0),
 	fMax(DBL_MAX),
@@ -353,6 +346,5 @@ Variable::Variable(LinearSpec* ls)
 Variable::~Variable()
 {
 	Invalidate();
-	delete fUsingSummands;
 }