From 446139c354033ac2f0d81a0806d03083767293b8 Mon Sep 17 00:00:00 2001 From: John Scipione Date: Wed, 12 Aug 2026 23:01:56 -0400 Subject: [PATCH] Deskbar: Fix open prefs window incorrectly sets Deskbar window state. Set window location but do not Invoke() when opening prefs window. We do not want the Deskbar window location to change on open/show prefs window, only when you change the preference. The root problem here is that we currently do not support horizontal mini-mode in Deskbar preferences, only vertical. Consequently, opening the prefs window switches Deskbar into vertical mini-mode when in horizontal mini-mode. Leave the state alone so this doesn't happen. Change-Id: Ife00e02f4bc16344fed47d23b9d768aa46b8d7f7 Reviewed-on: https://review.haiku-os.org/c/haiku/+/11524 Haiku-Format: Haiku-format Bot Tested-by: Commit checker robot Reviewed-by: waddlesplash (cherry picked from commit 6674947bb98ba64da5af9d5de6f894850a194b98) Reviewed-on: https://review.haiku-os.org/c/haiku/+/11533 --- src/apps/deskbar/PreferencesWindow.cpp | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/src/apps/deskbar/PreferencesWindow.cpp b/src/apps/deskbar/PreferencesWindow.cpp index 2e08df3e98..5a24a5fd17 100644 --- a/src/apps/deskbar/PreferencesWindow.cpp +++ b/src/apps/deskbar/PreferencesWindow.cpp @@ -242,8 +242,6 @@ PreferencesWindow::PreferencesWindow(BRect frame) .SetInsets(B_USE_WINDOW_SPACING) .End(); - fWindowLocation->Invoke(); - BMessage windowSettings; BPoint where; if (_LoadSettings(&windowSettings) == B_OK @@ -330,10 +328,8 @@ PreferencesWindow::Show() // refresh window location from settings desk_settings* settings = static_cast(be_app)->Settings(); - if (settings != NULL) { + if (settings != NULL) _SetWindowLocation(settings->vertical, settings->left, settings->top, settings->state); - fWindowLocation->Invoke(); - } _UpdateButtons();